Subject: Re: [PATCH -mm 1/5] list.h: add list_singleton
From: Peter Zijlstra <a.p.zijlstra@chello.nl>
To: Masami Hiramatsu <mhiramat@redhat.com>
Cc: Andrew Morton <akpm@linux-foundation.org>, ananth@in.ibm.com,
       jkenisto@us.ibm.com, linux-kernel@vger.kernel.org,
       systemtap@sources.redhat.com, prasanna@in.ibm.com, shaohua.li@intel.com,
       davem@davemloft.net, fche@redhat.com
In-Reply-To: <47DE8870.1020503@redhat.com>
References: <47DAE2C4.2060303@redhat.com>
	 <20080314140007.a7b495d7.akpm@linux-foundation.org>
	 <47DAFAA2.20302@redhat.com> <1205620596.6422.8.camel@lappy>
	 <47DE8870.1020503@redhat.com>
Content-Type: text/plain
Date: Mon, 17 Mar 2008 16:13:18 +0100
Message-Id: <1205766798.8514.318.camel@twins>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 960
Lines: 28

On Mon, 2008-03-17 at 11:04 -0400, Masami Hiramatsu wrote:
> Hi Peter,
> 
> Peter Zijlstra wrote:
> >>> So I guess we can proceed with your list_singleton(), but I'd just like to
> >>> flag this possible confusion, see what people think..
> > 
> > May I kindly ask to please not use the singleton name like this. It does
> > not implement the singleton pattern and will be a great confusion for
> > everybody who expects it to.
> 
> Indeed.
> 
> I have some other candidates.
> - list_single
> - list_has_one
> - list_one
> 
> Could you tell me which or some other name you recommend?

I think list_has_one() or list_is_singular() are good names, they convey
they are a test for a condition by using a form of be.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/