Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756045AbYCRAU0 (ORCPT ); Mon, 17 Mar 2008 20:20:26 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752754AbYCRAUO (ORCPT ); Mon, 17 Mar 2008 20:20:14 -0400 Received: from lixom.net ([66.141.50.11]:40386 "EHLO mail.lixom.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752312AbYCRAUN (ORCPT ); Mon, 17 Mar 2008 20:20:13 -0400 Date: Mon, 17 Mar 2008 19:27:26 -0500 From: Olof Johansson To: Dan Williams Cc: shannon.nelson@intel.com, linux-kernel@vger.kernel.org, pasemi-linux@ozlabs.org, linuxppc-dev@ozlabs.org, hskinnemoen@atmel.com Subject: Re: [PATCH v2] pasemi_dma: Driver for PA Semi PWRficient on-chip DMA engine Message-ID: <20080318002726.GA481@lixom.net> References: <20080306233900.GA3969@lixom.net> <20080316213002.GA2589@lixom.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1179 Lines: 28 On Mon, Mar 17, 2008 at 11:46:39AM -0700, Dan Williams wrote: > Looks good, makes me want to go back and cleanup iop-adma a bit. A > few fyi's below, but no other review comments. > > > Note that this still needs to go on top of the powerpc.git tree due to the > > pasemi_dma.h updates that this driver depends on. I suggest merging this > > through pasemi.git->powerpc.git->linus with an Acked-by from the DMA guys. > > Ok, it still may not compile in mainline until after 2.6.26-rc1 due to > additional dmaengine cleanups like the ack-to-flags change I posted > earlier. Any better way to handle this? Go through -mm? Either go through -mm where Andrew can keep it applied in appropriate order and send upstream, or just merge it late. It's a new driver, and they're normally OK to go in a little later. That might be the easiest solution in this case. > Acked-by: Dan Williams Thanks! -Olof -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/