Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754657AbYCRAbU (ORCPT ); Mon, 17 Mar 2008 20:31:20 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752202AbYCRAbJ (ORCPT ); Mon, 17 Mar 2008 20:31:09 -0400 Received: from gw1.kapitza.umos.ru ([217.67.113.134]:38518 "EHLO ari.home" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752140AbYCRAbI (ORCPT ); Mon, 17 Mar 2008 20:31:08 -0400 X-Greylist: delayed 376 seconds by postgrey-1.27 at vger.kernel.org; Mon, 17 Mar 2008 20:31:08 EDT Date: Tue, 18 Mar 2008 03:24:59 +0300 (MSK) From: "Lev A. Melnikovsky" To: David Brownell cc: Rene Herman , Alessandro Suardi , Linux Kernel Subject: Re: ehci-hcd affects hda speed In-Reply-To: <200803171700.26274.david-b@pacbell.net> Message-ID: References: <200803171400.40045.david-b@pacbell.net> <47DEFD85.1050706@keyaccess.nl> <200803171700.26274.david-b@pacbell.net> User-Agent: Alpine 1.00 (LFD 882 2007-12-20) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=KOI8-R Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1082 Lines: 25 On Mon, 17 Mar 2008 at 11:26pm, Rene Herman wrote: RH> And, as usual, I can not reach Lev as some mailer along the way is RH> telling me his address is unroutable. I'm here, don't worry :-) On Mon, 17 Mar 2008 at 4:00pm, David Brownell wrote: DB> On Monday 17 March 2008, Rene Herman wrote: DB> > +???????case PCI_VENDOR_ID_VIA: DB> > +???????????????if (pdev->device == 0x3104 && pdev->revision >= 0x60) { DB> Unless you have specific docs from VIA saying that this register DB> isn't revision-specific (at least in the sense that all revisions DB> after 0x60 define that bit in that way), this should probably be a DB> switch on pdev->revision and just include the known-safe revisions. May I suggest this should be a module parameter? Because a side effect is a USB slow-down, which may be more important for somebody... -L -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/