Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753842AbYCRBBS (ORCPT ); Mon, 17 Mar 2008 21:01:18 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751659AbYCRBBK (ORCPT ); Mon, 17 Mar 2008 21:01:10 -0400 Received: from e5.ny.us.ibm.com ([32.97.182.145]:34088 "EHLO e5.ny.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752320AbYCRBBI (ORCPT ); Mon, 17 Mar 2008 21:01:08 -0400 Subject: Re: [PATCH 7/8] Remove current_tick_length() From: john stultz To: Roman Zippel Cc: Ray Lee , linux-kernel@vger.kernel.org, akpm@linux-foundation.org In-Reply-To: References: <20080314184001.695807682@linux-m68k.org> <20080314195737.153531685@linux-m68k.org> <1205548860.6122.55.camel@localhost.localdomain> <1205552909.6122.63.camel@localhost.localdomain> <2c0942db0803150929q7cc628f8h18269f10daec8ab1@mail.gmail.com> Content-Type: text/plain Date: Mon, 17 Mar 2008 18:01:04 -0700 Message-Id: <1205802064.28128.74.camel@localhost> Mime-Version: 1.0 X-Mailer: Evolution 2.12.1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 912 Lines: 27 On Sat, 2008-03-15 at 18:14 +0100, Roman Zippel wrote: > Hi, > > On Sat, 15 Mar 2008, Ray Lee wrote: > > > Then make the original function an inline. With -O2 it should compile > > to exactly the same thing. > > This would also defeat John's intention of keeping the value static. Well, don't mistake me for being fanatical about it. Having the values be static is cleaner, but if its a real performance issue, then clearly performance wins. I do like Ray's suggestion, and think using the inline'd function is preferred to the raw variable, as it better establishes through use if nothing else, the read-only nature of the value outside of ntp. thanks -john -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/