Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754856AbYCRB0j (ORCPT ); Mon, 17 Mar 2008 21:26:39 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752777AbYCRB0a (ORCPT ); Mon, 17 Mar 2008 21:26:30 -0400 Received: from smtpq1.tilbu1.nb.home.nl ([213.51.146.200]:55479 "EHLO smtpq1.tilbu1.nb.home.nl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752705AbYCRB03 (ORCPT ); Mon, 17 Mar 2008 21:26:29 -0400 Message-ID: <47DF1A7E.30809@keyaccess.nl> Date: Tue, 18 Mar 2008 02:27:26 +0100 From: Rene Herman User-Agent: Thunderbird 2.0.0.12 (X11/20080213) MIME-Version: 1.0 To: "Lev A. Melnikovsky" CC: David Brownell , Alessandro Suardi , Linux Kernel Subject: Re: ehci-hcd affects hda speed References: <200803171400.40045.david-b@pacbell.net> <47DEFD85.1050706@keyaccess.nl> <200803171700.26274.david-b@pacbell.net> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -1.0 (-) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 981 Lines: 21 On 18-03-08 01:24, Lev A. Melnikovsky wrote: > DB> On Monday 17 March 2008, Rene Herman wrote: > DB> > + case PCI_VENDOR_ID_VIA: > DB> > + if (pdev->device == 0x3104 && pdev->revision >= 0x60) { > DB> Unless you have specific docs from VIA saying that this register > DB> isn't revision-specific (at least in the sense that all revisions > DB> after 0x60 define that bit in that way), this should probably be a > DB> switch on pdev->revision and just include the known-safe revisions. > May I suggest this should be a module parameter? Because a side effect is > a USB slow-down, which may be more important for somebody... If the 10us is a EHCI specification, I'd personally think not. But if need be... Rene. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/