Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753276AbYCRLWS (ORCPT ); Tue, 18 Mar 2008 07:22:18 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752655AbYCRLWF (ORCPT ); Tue, 18 Mar 2008 07:22:05 -0400 Received: from wf-out-1314.google.com ([209.85.200.171]:42102 "EHLO wf-out-1314.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752588AbYCRLWE convert rfc822-to-8bit (ORCPT ); Tue, 18 Mar 2008 07:22:04 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=googlemail.com; s=gamma; h=message-id:date:from:reply-to:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=XI3bocNde+2804PXFjiu6vAWGdA+CFhm8TivP3c2RqBeV7T9N0/ZEb/39iHsdx/1i0ca4Ro0GrjnTS7okngWl5bnt22/n8HsL+gCxomSD5+PzJgU1a/G1yBO46eeE5mbbRSYZK5njZndoSpVnaBoOhpsoiZA+rfQj84lhBizCTs= Message-ID: <9ea470500803180422s491622d4i81f8e37796f44313@mail.gmail.com> Date: Tue, 18 Mar 2008 12:22:02 +0100 From: "Boris Petkov" Reply-To: petkovbb@gmail.com To: "Jens Axboe" Subject: Re: ide_cd modifies hard_* members of request Cc: "Nikanth Karthikesan" , "Bartlomiej Zolnierkiewicz" , linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org In-Reply-To: <20080318110803.GV17940@kernel.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT Content-Disposition: inline References: <1205830486.7126.16.camel@nikanth-laptop.blr.novell.com> <9ea470500803180405h5ede15eaqa86515058a632e2b@mail.gmail.com> <20080318110803.GV17940@kernel.dk> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1719 Lines: 54 On Tue, Mar 18, 2008 at 12:08 PM, Jens Axboe wrote: > > On Tue, Mar 18 2008, Boris Petkov wrote: > > (sorry, forgot to cc all) > > > > On Tue, Mar 18, 2008 at 9:54 AM, Nikanth Karthikesan wrote: > > > Hi > > > > > > Despite the warning in blkdev.h, that members of struct request starting > > > with hard_* are block layer internals, and no driver should touch them, > > > the ide_cd driver seems to fiddle around with it. > > > > > > Is this reqd, or can this be made to work without the need for this? > > > > > > If this reqd, why not provide a helper function for that in block layer > > > itself, may be, with a warning about usage? > > > > > > Thanks > > > Nikanth Karthikesan > > > > Hi, > > > > the code pieces you're referring to are in there since at least the > > first git import of the kernel source (i.e. 2005) aka long time so > > Bart/Jens should know that... > > restore_request(), I'm assuming. It was probably me who modified this > code, I don't think there's any justification for it. I would suggest > killing it. I'll conjure up something later wrt above. > And cdrom_read_from_buffer() as well, it's a silly addition. This one is already gone, however the patch is still in Bart's tree for -mm testing: ftp://ftp.fi.kernel.org/pub/linux/kernel/people/bart/pata-2.6/patches/ide-cd-remove-the-internal-64k-buffer.patch > > -- > Jens Axboe > > -- Regards/Gru?, Boris -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/