Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S936768AbYCSVQd (ORCPT ); Wed, 19 Mar 2008 17:16:33 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1761896AbYCST7q (ORCPT ); Wed, 19 Mar 2008 15:59:46 -0400 Received: from gprs189-60.eurotel.cz ([160.218.189.60]:36155 "EHLO gprs189-60.eurotel.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1761901AbYCST7e (ORCPT ); Wed, 19 Mar 2008 15:59:34 -0400 Date: Wed, 19 Mar 2008 10:15:27 +0100 From: Pavel Machek To: Greg KH Cc: "Rafael J. Wysocki" , pm list , ACPI Devel Maling List , Alan Stern , Len Brown , LKML , Alexey Starikovskiy , David Brownell Subject: Re: [RFC][PATCH 1/3] PM: Introduce new top level suspend and hibernation callbacks Message-ID: <20080319091526.GA1938@elf.ucw.cz> References: <200803170020.55473.rjw@sisk.pl> <200803170022.30345.rjw@sisk.pl> <20080319005340.GC8298@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20080319005340.GC8298@kroah.com> X-Warning: Reading this can be dangerous to your mental health. User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1856 Lines: 50 On Tue 2008-03-18 17:53:40, Greg KH wrote: > On Mon, Mar 17, 2008 at 12:22:29AM +0100, Rafael J. Wysocki wrote: > > From: Rafael J. Wysocki > > > > Introduce 'struct pm_ops' representing a set of suspend and > > hibernation operations for bus types, device classes and device > > types. > > Ok, I must have missed the thread describing why we need to do this, so, > why do we need to do this? What is this going to buy us in the end > after everything is changed? That was rather long thread where Linus flamed us for having everything in one "suspend" callback, selecting what to do by pm_message_t parameter. It was kind of hard to miss ;-). Pavel > > +struct pm_ops { > > +#ifdef CONFIG_PM_SLEEP > > + int (*prepare)(struct device *dev); > > + void (*complete)(struct device *dev); > > +#endif > > +#ifdef CONFIG_SUSPEND > > + int (*suspend)(struct device *dev); > > + int (*resume)(struct device *dev); > > +#endif > > +#ifdef CONFIG_HIBERNATION > > + int (*freeze)(struct device *dev); > > + int (*thaw)(struct device *dev); > > + int (*poweroff)(struct device *dev); > > + int (*quiesce)(struct device *dev); > > + int (*restore)(struct device *dev); > > + int (*recover)(struct device *dev); > > +#endif > > > Don't ifdef stuff like this, it only causes ifdefs to be needed to the > .c code as well for all places these structures are defined in > drivers/busses, right? -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html pomozte zachranit klanovicky les: http://www.ujezdskystrom.info/ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/