Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S938495AbYCSVqB (ORCPT ); Wed, 19 Mar 2008 17:46:01 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1765578AbYCSUQZ (ORCPT ); Wed, 19 Mar 2008 16:16:25 -0400 Received: from mga02.intel.com ([134.134.136.20]:1833 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757339AbYCSUQX (ORCPT ); Wed, 19 Mar 2008 16:16:23 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.25,526,1199692800"; d="scan'208";a="357375088" Date: Wed, 19 Mar 2008 13:09:31 -0700 From: Venki Pallipadi To: Pavel Machek Cc: Venki Pallipadi , Len Brown , "Rafael J. Wysocki" , Miklos Szeredi , linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: ACPI lockdep warning on boot, 2.6.25-rc5 Message-ID: <20080319200931.GA1525@linux-os.sc.intel.com> References: <200803122301.17356.rjw@sisk.pl> <200803131614.33386.lenb@kernel.org> <20080314001819.GA32584@linux-os.sc.intel.com> <20080315131611.GA4828@ucw.cz> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20080315131611.GA4828@ucw.cz> User-Agent: Mutt/1.4.1i Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1253 Lines: 46 On Sat, Mar 15, 2008 at 02:16:11PM +0100, Pavel Machek wrote: > Hi! > > > @@ -421,7 +423,9 @@ > > else > > acpi_safe_halt(); > > > > - local_irq_enable(); > > + if (irqs_disabled()) > > + local_irq_enable(); > > + > > return; > > } > > > > @@ -530,7 +534,9 @@ > > * skew otherwise. > > */ > > sleep_ticks = 0xFFFFFFFF; > > - local_irq_enable(); > > + if (irqs_disabled()) > > + local_irq_enable(); > > + > > break; > > > > case ACPI_STATE_C2: > > That's pretty ugly. Could the code be modified to have interrupt > consistent at this point? > Agreed that this is not very clean. The problem is that we cannot be sure about the interrupt state at this point as the low level idle handlers at this point can come from variety of different places like safe_halt, arch dependent pm_idle code (which is different for (32 and 64 bit at this point) and also pm_idle can be somewhere outside the kernel in some module as it is a function pointer. Thanks, Venki -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/