Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S940793AbYCSWVr (ORCPT ); Wed, 19 Mar 2008 18:21:47 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1763094AbYCSU5s (ORCPT ); Wed, 19 Mar 2008 16:57:48 -0400 Received: from gprs189-60.eurotel.cz ([160.218.189.60]:42598 "EHLO gprs189-60.eurotel.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S935533AbYCSU5p (ORCPT ); Wed, 19 Mar 2008 16:57:45 -0400 Date: Wed, 19 Mar 2008 21:58:12 +0100 From: Pavel Machek To: Alexey Starikovskiy Cc: Linus Torvalds , "Rafael J. Wysocki" , pm list , ACPI Devel Maling List , Alan Stern , David Brownell , Greg KH , Len Brown , LKML , Shaohua Li , Johannes Berg Subject: Re: suspend slow in 2.6.25-rc6 (was Re: Suspend and hibernation patchset against -rc6) Message-ID: <20080319205812.GC1811@elf.ucw.cz> References: <200803172317.33745.rjw@sisk.pl> <20080318130642.GA1609@elf.ucw.cz> <20080318130710.GB1609@elf.ucw.cz> <20080318225201.GA2115@elf.ucw.cz> <20080319114851.GB21270@atrey.karlin.mff.cuni.cz> <20080319202323.GA1811@elf.ucw.cz> <47E178FE.6050500@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <47E178FE.6050500@suse.de> X-Warning: Reading this can be dangerous to your mental health. User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2003 Lines: 51 On Wed 2008-03-19 23:35:10, Alexey Starikovskiy wrote: > Pavel Machek wrote: >> Hi! >> >>>> Ok, 7c0... is innocent. Reverting not only the mdelay, but also rest >>>> of drivers/acpi/ec.c patch fixed the >>>> "rc6-breaks-backlight-in-X-over-lid-close", good. >>> Can you clarify a bit? >>> >>> Do you mean that the full revert of 2c81ce4 that already got committed is >>> sufficient for you, or do you need to totally undo everything we've done >>> to ec.c since -rc5, and thus also to revert the _other_ revert we did (in >>> 4af8e10a6c57e7292862bd1703712f0565c7e429)? >> >> I did some more testing, and realized I was wrong. We need to totally >> undo everything we've done to ec.c since -rc5... (that has small >> sideffect of brightness up/down keys no longer working -- regression >> since 2.6.24, but saves us from "backlight gone after >> closing/reopening lid" which is _NASTY_ regression from 2.6.25-rc5). >> >> ACPI sucks. >> >> I.e. this patch: >> >> >> Revert ec.c to 2.6.25-rc5 state: >> >> * this fixes backlight after closing/reopening the lid while in X on >> thinkpad x60 >> >> * unfortunately it breaks fn-home/end keyboard brightness control > It should also break volume up/down/mute keys. Essentially all the keys on Thinkpad. > And it would also be regression to 2.6.24 level. As I explained above. Unfortunately, applying this means I loose screen as soon as I close/reopen lid. 2.6.24 did not behave like that. And it makes my machine mostly unusable -- as soon as you try to carry it away, you loose video. BAD. Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html pomozte zachranit klanovicky les: http://www.ujezdskystrom.info/ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/