Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1162192AbYCSWqn (ORCPT ); Wed, 19 Mar 2008 18:46:43 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S936747AbYCSVQa (ORCPT ); Wed, 19 Mar 2008 17:16:30 -0400 Received: from gw.goop.org ([64.81.55.164]:47616 "EHLO mail.goop.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S936743AbYCSVQ3 (ORCPT ); Wed, 19 Mar 2008 17:16:29 -0400 Message-ID: <47E181D9.3060802@goop.org> Date: Wed, 19 Mar 2008 14:12:57 -0700 From: Jeremy Fitzhardinge User-Agent: Thunderbird 2.0.0.12 (X11/20080226) MIME-Version: 1.0 To: Ingo Molnar CC: LKML , Ian Campbell Subject: Re: [PATCH 00 of 31] x86: unification and xen updates References: <20080319190536.GA11432@elte.hu> <20080319194648.GA20088@elte.hu> <47E17171.9090108@goop.org> <20080319200931.GA24828@elte.hu> In-Reply-To: <20080319200931.GA24828@elte.hu> X-Enigmail-Version: 0.95.6 Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1386 Lines: 46 Ingo Molnar wrote: > * Jeremy Fitzhardinge wrote: > > >>> i've uninlined it and has trickled that through your series. >>> >> I build 32-bit PAE all the time. I guess the difference is your build >> is !PARAVIRT? >> > > yes, randconfig triggered it rather quickly. Bad config attached. (it > now builds fine) > > Ingo > This patch applied on top of everything else is sufficient to fix the problem for me: Subject: x86: fix build problem in pud_populate without CONFIG_PARAVIRT asm/paravirt.h ends up including linux/sched.h, which pud_populate needs for its reference to current. Specifically include linux/sched.h for it. Signed-off-by: Jeremy Fitzhardinge --- include/asm-x86/pgalloc.h | 1 + 1 file changed, 1 insertion(+) =================================================================== --- a/include/asm-x86/pgalloc.h +++ b/include/asm-x86/pgalloc.h @@ -4,6 +4,7 @@ #include #include /* for struct page */ #include +#include #ifdef CONFIG_PARAVIRT #include -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/