Message-ID: <47E09F53.5020201@permonline.ru>
Date: Wed, 19 Mar 2008 10:06:27 +0500
From: "Artem S. Tashkinov" <birdie@permonline.ru>
User-Agent: Thunderbird 3.0a1pre (X11/2008031803)
MIME-Version: 1.0
To: Jan Engelhardt <jengelh@computergmbh.de>
CC: linux-kernel@vger.kernel.org
Subject: Re: GIT commit description flag(s)
References: <47DC4104.1070109@permonline.ru> <alpine.LNX.1.00.0803181757020.8851@fbirervta.pbzchgretzou.qr>
In-Reply-To: <alpine.LNX.1.00.0803181757020.8851@fbirervta.pbzchgretzou.qr>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1320
Lines: 35

I quite agree with you that the description is already there, but such 
flags could help easily review or grep commits in order to identify your 
areas of interest.

Even your example has ambiguity: "Wire up new timerfd syscalls" - It's 
not easy to understand whether this particular commit is a bugfix, or it 
speeds up things, or the old code which has been cleaned up, etc.

Jan Engelhardt wrote:
>
> On Mar 16 2008 02:35, Artem S. Tashkinov wrote:
>> It would be nice if [kernel] git commits had a flag [a char] (or a
>> combination of) describing their main purpose which could be the
>> following:
>>
>> bug Fix [F]
>> Speed up/Performance [S]
>> Revert [R]
>> New functionality [N]
>
> Usually you already give the type implicitly in the commit:
>
> dfd347f... HID: fix comment in hid_input_report()
> fa331ff... [S390] sclp_vt220: speed up console output for interactive work
> d9452e9... [NETPOLL]: Revert two bogus cleanups that broke netconsole.
> 8727e28... m68k{,nommu}: Wire up new timerfd syscalls
> b863ceb... [NET]: Add macvlan driver
>
> So all is well.
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/