From: Arnd Bergmann <arnd@arndb.de>
To: Heiko Carstens <heiko.carstens@de.ibm.com>
Subject: Re: tick-common.c hack for s390 needed
Date: Wed, 19 Mar 2008 05:12:57 +0100
User-Agent: KMail/1.9.9
Cc: Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@elte.hu>,
       linux-kernel@vger.kernel.org,
       Martin Schwidefsky <schwidefsky@de.ibm.com>
References: <20080318093119.GA8669@osiris.boeblingen.de.ibm.com>
In-Reply-To: <20080318093119.GA8669@osiris.boeblingen.de.ibm.com>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200803190512.58703.arnd@arndb.de>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 856
Lines: 26

On Tuesday 18 March 2008, Heiko Carstens wrote:
> Actually there's a huge #ifndef CONFIG_S390 in linux/irq.h ;)
> 
> To make the code work the patch below is necessary. It's ok since all
> clock event devices on s390 are per cpu. However I think this patch is
> ugly at best. Any ideas how to fix this in a better and more generic way?

You could have an #else path in linux/irq.h to just define these
functions as s390, maybe like

static inline int irq_set_affinity(unsigned int irq, cpumask_t cpumask)
{
	BUG();
	return 0;
}
static inline int irq_can_set_affinity(unsigned int irq)
{
	return 0;
}

	Arnd <><
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/