Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758149AbYCTVGr (ORCPT ); Thu, 20 Mar 2008 17:06:47 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755079AbYCTVGi (ORCPT ); Thu, 20 Mar 2008 17:06:38 -0400 Received: from relay2.sgi.com ([192.48.171.30]:49714 "EHLO relay.sgi.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754842AbYCTVGh (ORCPT ); Thu, 20 Mar 2008 17:06:37 -0400 Date: Thu, 20 Mar 2008 14:05:06 -0700 (PDT) From: Christoph Lameter X-X-Sender: clameter@schroedinger.engr.sgi.com To: akpm@linux-foundation.org, yanmin_zhang@linux.intel.com cc: LKML , Pekka Enberg , Mel Gorman , Matt Mackall , linux-mm@kvack.org Subject: Re: [patch 2/9] Store max number of objects in the page struct. In-Reply-To: <1205983937.14496.24.camel@ymzhang> Message-ID: References: <20080317230516.078358225@sgi.com> <20080317230528.279983034@sgi.com> <1205917757.10318.1.camel@ymzhang> <1205983937.14496.24.camel@ymzhang> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2117 Lines: 73 Reviewed-by: Christoph Lameter On Thu, 20 Mar 2008, Zhang, Yanmin wrote: > On Wed, 2008-03-19 at 10:49 -0700, Christoph Lameter wrote: > > On Wed, 19 Mar 2008, Zhang, Yanmin wrote: > > > > > > + if ((PAGE_SIZE << min_order) / size > 65535) > > > > + return get_order(size * 65535) - 1; > > > Is it better to define something like USHORT_MAX to replace 65535? > > > > Yes. Do we have something like that? > > I couldn't find such definition in include/linux/kernel.h. > > > But glibc defines USHRT_MAX file include/limits.h: > > /* Minimum and maximum values a `signed short int' can hold. */ > # define SHRT_MIN (-32768) > # define SHRT_MAX 32767 > > /* Maximum value an `unsigned short int' can hold. (Minimum is 0.) */ > # define USHRT_MAX 65535 > > > How about below patch against 2.6.25-rc6? > > --- > > Add definitions of USHRT_MAX and others into kernel. ipc uses it and > slub implementation might also use it. > > The patch is against 2.6.25-rc6. > > Signed-off-by: Zhang Yanmin > > --- > > --- linux-2.6.25-rc6/include/linux/kernel.h 2008-03-20 04:25:46.000000000 +0800 > +++ linux-2.6.25-rc6_work/include/linux/kernel.h 2008-03-20 04:17:45.000000000 +0800 > @@ -20,6 +20,9 @@ > extern const char linux_banner[]; > extern const char linux_proc_banner[]; > > +#define USHRT_MAX ((u16)(~0U)) > +#define SHRT_MAX ((s16)(USHRT_MAX>>1)) > +#define SHRT_MIN (-SHRT_MAX - 1) > #define INT_MAX ((int)(~0U>>1)) > #define INT_MIN (-INT_MAX - 1) > #define UINT_MAX (~0U) > --- linux-2.6.25-rc6/ipc/util.h 2008-03-20 04:25:46.000000000 +0800 > +++ linux-2.6.25-rc6_work/ipc/util.h 2008-03-20 04:22:07.000000000 +0800 > @@ -12,7 +12,6 @@ > > #include > > -#define USHRT_MAX 0xffff > #define SEQ_MULTIPLIER (IPCMNI) > > void sem_init (void); > > > > > > > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/