Subject: Re: [PATCH] Add definitions of USHRT_MAX
From: Joe Perches <joe@perches.com>
To: "Zhang, Yanmin" <yanmin_zhang@linux.intel.com>
Cc: LKML <linux-kernel@vger.kernel.org>, Christoph Lameter <clameter@sgi.com>,
       linux-mm@kvack.org, Andrew Morton <akpm@linux-foundation.org>
In-Reply-To: <1206063614.14496.72.camel@ymzhang>
References: <1206063614.14496.72.camel@ymzhang>
Content-Type: text/plain
Date: Thu, 20 Mar 2008 18:51:18 -0700
Message-Id: <1206064278.26345.108.camel@localhost>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 707
Lines: 18

On Fri, 2008-03-21 at 09:40 +0800, Zhang, Yanmin wrote:
> Add definitions of USHRT_MAX and others into kernel. ipc uses it and
> slub implementation might also use it.
> +#define USHRT_MAX	((u16)(~0U))
> +#define SHRT_MAX	((s16)(USHRT_MAX>>1))
> +#define SHRT_MIN	(-SHRT_MAX - 1)

Perhaps it's better to use the most common kernel types?
Perhaps U16_MAX, S16_MAX and S16_MIN?

Don't you need to cast SHRT_MIN/S16_MIN too?
#define S16_MIN ((s16)(-SHRT_MAX - 1))

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/