Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753548AbYCUEOO (ORCPT ); Fri, 21 Mar 2008 00:14:14 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751106AbYCUEN5 (ORCPT ); Fri, 21 Mar 2008 00:13:57 -0400 Received: from fgwmail6.fujitsu.co.jp ([192.51.44.36]:35429 "EHLO fgwmail6.fujitsu.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750952AbYCUEN4 (ORCPT ); Fri, 21 Mar 2008 00:13:56 -0400 Message-ID: <47E335AB.6020709@jp.fujitsu.com> Date: Fri, 21 Mar 2008 13:12:27 +0900 From: Kenji Kaneshige User-Agent: Thunderbird 2.0.0.12 (Windows/20080213) MIME-Version: 1.0 To: Alex Chiang , Greg KH CC: Gary Hade , Kristen Carlson Accardi , Matthew Wilcox , warthog19@eaglescrag.net, rick.jones2@hp.com, linux-kernel@vger.kernel.org, linux-pci@atrey.karlin.mff.cuni.cz, linux-acpi@vger.kernel.org Subject: [PATCH 4/16][BUG] PCI slot: Add missing semaphore for slot release (Not for mainline!) References: <20080318210539.GA30421@ldl.fc.hp.com> <47E33472.1000602@jp.fujitsu.com> In-Reply-To: <47E33472.1000602@jp.fujitsu.com> Content-Type: text/plain; charset=ISO-2022-JP Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1044 Lines: 31 Add missing pci_bus sem into pci_destroy_slot(). There is possible race condition because current code doesn't have any serialization in the destroy path. Signed-off-by: Kenji Kaneshige --- drivers/pci/slot.c | 2 ++ 1 file changed, 2 insertions(+) Index: linux-2.6.25-rc6/drivers/pci/slot.c =================================================================== --- linux-2.6.25-rc6.orig/drivers/pci/slot.c +++ linux-2.6.25-rc6/drivers/pci/slot.c @@ -196,7 +196,9 @@ EXPORT_SYMBOL_GPL(pci_create_slot); int pci_destroy_slot(struct pci_slot *slot) { + down_write(&pci_bus_sem); kobject_put(&slot->kobj); + up_write(&pci_bus_sem); dbg("%s: decreased refcount to %d on %x:%d\n", __func__, slot->kobj.kref.refcount, slot->bus->number, slot->number); -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/