Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755021AbYCUJxr (ORCPT ); Fri, 21 Mar 2008 05:53:47 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753249AbYCUJxi (ORCPT ); Fri, 21 Mar 2008 05:53:38 -0400 Received: from zone0.gcu-squad.org ([212.85.147.21]:31701 "EHLO services.gcu-squad.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753244AbYCUJxh (ORCPT ); Fri, 21 Mar 2008 05:53:37 -0400 Date: Fri, 21 Mar 2008 10:53:11 +0100 From: Jean Delvare To: Andrew Morton Cc: Alan Stern , Michael Buesch , Henrique de Moraes Holschuh , David Brownell , Richard Purdie , , Ingo Molnar , Geert Uytterhoeven Subject: Re: use of preempt_count instead of in_atomic() at leds-gpio.c Message-ID: <20080321105311.1a55cc0f@hyperion.delvare> In-Reply-To: <20080320201723.b87b3732.akpm@linux-foundation.org> References: <20080320192719.6a32386e.akpm@linux-foundation.org> <20080320201723.b87b3732.akpm@linux-foundation.org> X-Mailer: Claws Mail 3.3.1 (GTK+ 2.10.6; x86_64-suse-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 712 Lines: 16 On Thu, 20 Mar 2008 20:17:23 -0700, Andrew Morton wrote: > in_atomic() is for core kernel use only. (...) Then why is it made available to drivers through ? If it's such a dangerous macro to call from drivers, it shouldn't be made available, or at the very least there should be a big fat warning in that drivers aren't supposed to use it. This would have avoided the 23 uses cases in drivers we have right now. -- Jean Delvare -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/