Date: Fri, 21 Mar 2008 11:39:46 +0100
From: Ingo Molnar <mingo@elte.hu>
To: Roland McGrath <roland@redhat.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
       Andrew Morton <akpm@linux-foundation.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86 handle_vm86_trap cleanup
Message-ID: <20080321103946.GO20420@elte.hu>
References: <20080317092108.EC6C626F995@magilla.localdomain>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20080317092108.EC6C626F995@magilla.localdomain>
User-Agent: Mutt/1.5.17 (2007-11-01)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1083
Lines: 32


* Roland McGrath <roland@redhat.com> wrote:

> Use force_sig in handle_vm86_trap like other machine traps do.

thanks, applied.

> -	if (current->ptrace & PT_PTRACED) {
> -		unsigned long flags;
> -		spin_lock_irqsave(&current->sighand->siglock, flags);
> -		sigdelset(&current->blocked, SIGTRAP);
> -		recalc_sigpending();
> -		spin_unlock_irqrestore(&current->sighand->siglock, flags);
> -	}
> -	send_sig(SIGTRAP, current, 1);
>  	current->thread.trap_no = trapno;
>  	current->thread.error_code = error_code;
> +	force_sig(SIGTRAP, current);
>  	return 0;
>  }

for the record, this also changes semantics, because previously we'd 
permanently unblock SIGTRAP (most certainly as a hack, to be able to do 
the send_sig()), while now we use force_sig() which just ignores the 
blocked mask. (and i agree with your fix of course)

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/