Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756647AbYCUK6U (ORCPT ); Fri, 21 Mar 2008 06:58:20 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754091AbYCUK6G (ORCPT ); Fri, 21 Mar 2008 06:58:06 -0400 Received: from 81-174-11-161.static.ngi.it ([81.174.11.161]:57980 "EHLO mail.enneenne.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753820AbYCUK6F (ORCPT ); Fri, 21 Mar 2008 06:58:05 -0400 Date: Fri, 21 Mar 2008 11:57:59 +0100 From: Rodolfo Giometti To: Kay Sievers Cc: linux-kernel@vger.kernel.org, Andrew Morton , David Woodhouse , Dave Jones , Sam Ravnborg , Greg KH , Randy Dunlap Message-ID: <20080321105759.GB8959@enneenne.com> References: <12048053463198-git-send-email-giometti@linux.it> <12048053473401-git-send-email-giometti@linux.it> <3ae72650803202050y14cb890bjce643d933dec1cb5@mail.gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3ae72650803202050y14cb890bjce643d933dec1cb5@mail.gmail.com> Organization: GNU/Linux Device Drivers, Embedded Systems and Courses X-PGP-Key: gpg --keyserver keyserver.linux.it --recv-keys D25A5633 User-Agent: Mutt/1.5.16 (2007-06-11) X-SA-Exim-Connect-IP: 192.168.32.1 X-SA-Exim-Mail-From: giometti@enneenne.com Subject: Re: [PATCH 1/7] LinuxPPS core support. X-SA-Exim-Version: 4.2.1 (built Tue, 09 Jan 2007 17:23:22 +0000) X-SA-Exim-Scanned: Yes (on mail.enneenne.com) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2221 Lines: 60 On Fri, Mar 21, 2008 at 04:50:51AM +0100, Kay Sievers wrote: > On Thu, Mar 6, 2008 at 1:09 PM, Rodolfo Giometti wrote: > > This patch adds the kernel side of the PPS support currently named > > "LinuxPPS". > > > diff --git a/include/linux/pps.h b/include/linux/pps.h > > new file mode 100644 > > index 0000000..c455443 > > --- /dev/null > > +++ b/include/linux/pps.h > > @@ -0,0 +1,204 @@ > > > +/* The main struct */ > > +struct pps_device { > > + struct pps_source_info info; /* PSS source info */ > > + > > + struct pps_kparams params; /* PPS's current params */ > > + > > + __u32 assert_sequence; /* PPS' assert event seq # */ > > + __u32 clear_sequence; /* PPS' clear event seq # */ > > + struct pps_ktime assert_tu; > > + struct pps_ktime clear_tu; > > + int current_mode; /* PPS mode at event time */ > > + > > + int go; /* PPS event is arrived? */ > > + wait_queue_head_t queue; /* PPS event queue */ > > + > > + unsigned int id; /* PPS source unique ID */ > > + struct cdev cdev; > > + struct device *dev; > > + int devno; > > + struct fasync_struct *async_queue; /* fasync method */ > > + spinlock_t lock; > > + > > + atomic_t usage; /* usage count */ > > + wait_queue_head_t usage_queue; > > + > > + struct class class_dev; > > Why is an entire class embedded into every device? :) Uh! =:-o Is that not right? What do you suggest to do? Thanks, Rodolfo -- GNU/Linux Solutions e-mail: giometti@enneenne.com Linux Device Driver giometti@gnudd.com Embedded Systems giometti@linux.it UNIX programming phone: +39 349 2432127 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/