Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759816AbYCUQ6J (ORCPT ); Fri, 21 Mar 2008 12:58:09 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1757093AbYCUQ5y (ORCPT ); Fri, 21 Mar 2008 12:57:54 -0400 Received: from g1t0026.austin.hp.com ([15.216.28.33]:15241 "EHLO g1t0026.austin.hp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757073AbYCUQ5x (ORCPT ); Fri, 21 Mar 2008 12:57:53 -0400 Date: Fri, 21 Mar 2008 10:57:52 -0600 From: Alex Chiang To: Kenji Kaneshige Cc: Greg KH , Gary Hade , Kristen Carlson Accardi , Matthew Wilcox , warthog19@eaglescrag.net, rick.jones2@hp.com, linux-kernel@vger.kernel.org, linux-pci@atrey.karlin.mff.cuni.cz, linux-acpi@vger.kernel.org Subject: Re: [PATCH 4/16][BUG] PCI slot: Add missing semaphore for slot release (Not for mainline!) Message-ID: <20080321165752.GI17292@ldl.fc.hp.com> Mail-Followup-To: Alex Chiang , Kenji Kaneshige , Greg KH , Gary Hade , Kristen Carlson Accardi , Matthew Wilcox , warthog19@eaglescrag.net, rick.jones2@hp.com, linux-kernel@vger.kernel.org, linux-pci@atrey.karlin.mff.cuni.cz, linux-acpi@vger.kernel.org References: <20080318210539.GA30421@ldl.fc.hp.com> <47E33472.1000602@jp.fujitsu.com> <47E335AB.6020709@jp.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <47E335AB.6020709@jp.fujitsu.com> User-Agent: Mutt/1.5.16 (2007-06-09) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1171 Lines: 37 * Kenji Kaneshige : > Add missing pci_bus sem into pci_destroy_slot(). There is possible > race condition because current code doesn't have any serialization > in the destroy path. Merged, thanks. /ac > > Signed-off-by: Kenji Kaneshige > > --- > drivers/pci/slot.c | 2 ++ > 1 file changed, 2 insertions(+) > > Index: linux-2.6.25-rc6/drivers/pci/slot.c > =================================================================== > --- linux-2.6.25-rc6.orig/drivers/pci/slot.c > +++ linux-2.6.25-rc6/drivers/pci/slot.c > @@ -196,7 +196,9 @@ EXPORT_SYMBOL_GPL(pci_create_slot); > > int pci_destroy_slot(struct pci_slot *slot) > { > + down_write(&pci_bus_sem); > kobject_put(&slot->kobj); > + up_write(&pci_bus_sem); > > dbg("%s: decreased refcount to %d on %x:%d\n", __func__, > slot->kobj.kref.refcount, slot->bus->number, slot->number); > > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/