Date: Fri, 21 Mar 2008 10:41:25 -0700
From: Andrew Morton <akpm@linux-foundation.org>
To: Rodolfo Giometti <giometti@enneenne.com>
Cc: linux-kernel@vger.kernel.org, dwmw2@infradead.org, davej@redhat.com,
       sam@ravnborg.org, greg@kroah.com, randy.dunlap@oracle.com
Subject: Re: [PATCH 5/7] PPS: serial clients support.
Message-Id: <20080321104125.e1ff69c5.akpm@linux-foundation.org>
In-Reply-To: <20080321111736.GC8959@enneenne.com>
References: <12048053463198-git-send-email-giometti@linux.it>
	<12048053473401-git-send-email-giometti@linux.it>
	<12048053471754-git-send-email-giometti@linux.it>
	<12048053471177-git-send-email-giometti@linux.it>
	<12048053473741-git-send-email-giometti@linux.it>
	<12048053472063-git-send-email-giometti@linux.it>
	<20080320130400.0b17e1fc.akpm@linux-foundation.org>
	<20080321111736.GC8959@enneenne.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 995
Lines: 33

On Fri, 21 Mar 2008 12:17:36 +0100 Rodolfo Giometti <giometti@enneenne.com> wrote:

> > > +#else
> > > +
> > > +#define uart_register_pps_port(state, port)	do { } while (0)
> > > +#define uart_unregister_pps_port(state, port)	do { } while (0)
> > 
> > Please never implement in cpp that which can be implemented in C.  These
> > should have been static inlines.  That's nicer, matches the
> > CONFIG_PPS_CLIENT_UART=y code and provides type checking.
> 
> Are you saying that I should do:
> 
> static inline int
> uart_register_pps_port(struct uart_state *state, struct uart_port *port)
> {
> 	/* Nop */
> }
> 
> static inline void
> uart_unregister_pps_port(struct uart_state *state, struct uart_port *port)
> {
> 	/* Nop */
> }
> 
> ?

Yes please.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/