Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1762086AbYCUWno (ORCPT ); Fri, 21 Mar 2008 18:43:44 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756744AbYCUWna (ORCPT ); Fri, 21 Mar 2008 18:43:30 -0400 Received: from 74-93-104-97-Washington.hfc.comcastbusiness.net ([74.93.104.97]:57124 "EHLO sunset.davemloft.net" rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1756118AbYCUWn3 (ORCPT ); Fri, 21 Mar 2008 18:43:29 -0400 Date: Fri, 21 Mar 2008 15:43:40 -0700 (PDT) Message-Id: <20080321.154340.210302849.davem@davemloft.net> To: nix.or.die@googlemail.com Cc: linux-kernel@vger.kernel.org, vladislav.yasevich@hp.com, sri@us.ibm.com, netdev@vger.kernel.org Subject: Re: Commit 270637abff0cdf848b910b9f96ad342e1da61c66 introduced a lot new compiler warnings From: David Miller In-Reply-To: <47E40856.6020902@googlemail.com> References: <47E40856.6020902@googlemail.com> X-Mailer: Mew version 5.2 on Emacs 22.1 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1969 Lines: 49 From: Gabriel C Date: Fri, 21 Mar 2008 20:11:18 +0100 > I noticed the following new compile warnings on current git head introduced by 270637abff0cdf848b910b9f96ad342e1da61c66 : Please include netdev@vger.kernel.org for networking bug reports in the future, thank you. Thanks for the report, I'll push the following fix: commit 1233823b0847190976d69a86d7bb1287992ba2c7 Author: David S. Miller Date: Fri Mar 21 15:40:47 2008 -0700 [SCTP]: Fix build warnings with IPV6 disabled. Introduced by 270637abff0cdf848b910b9f96ad342e1da61c66 ("[SCTP]: Fix a race between module load and protosw access") Reported by Gabriel C: In file included from net/sctp/sm_statetable.c:50: include/net/sctp/sctp.h: In function 'sctp_v6_pf_init': include/net/sctp/sctp.h:392: warning: 'return' with a value, in function returning void In file included from net/sctp/sm_statefuns.c:62: include/net/sctp/sctp.h: In function 'sctp_v6_pf_init': include/net/sctp/sctp.h:392: warning: 'return' with a value, in function returning void ... Signed-off-by: David S. Miller diff --git a/include/net/sctp/sctp.h b/include/net/sctp/sctp.h index 57ed3e3..ea80673 100644 --- a/include/net/sctp/sctp.h +++ b/include/net/sctp/sctp.h @@ -389,7 +389,7 @@ void sctp_v6_del_protocol(void); #else /* #ifdef defined(CONFIG_IPV6) */ -static inline void sctp_v6_pf_init(void) { return 0; } +static inline void sctp_v6_pf_init(void) { return; } static inline void sctp_v6_pf_exit(void) { return; } static inline int sctp_v6_protosw_init(void) { return 0; } static inline void sctp_v6_protosw_exit(void) { return; } -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/