Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758148AbYCVAKy (ORCPT ); Fri, 21 Mar 2008 20:10:54 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753047AbYCVAKq (ORCPT ); Fri, 21 Mar 2008 20:10:46 -0400 Received: from hs-out-0708.google.com ([64.233.178.248]:22200 "EHLO hs-out-0708.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752956AbYCVAKp (ORCPT ); Fri, 21 Mar 2008 20:10:45 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=nEdlDpGRELzAv67n+EdNtYEkp1DVNDUFolCQ2ENWiGt/xELYOw21Zle+NN3i80u5jKbddJB2eJhoGGHz5Kj+iaj6If9OHrlNF3jyyS5q8y6AMlLbTsZYsWGor/A1m3PqygPSqU0IGbkV4jnKmCRBEfL4csucudJw47P4U6/Up9k= Message-ID: <9a8748490803211710u4c5d1d67x2a5a891347e0adf6@mail.gmail.com> Date: Sat, 22 Mar 2008 01:10:40 +0100 From: "Jesper Juhl" To: "Chris Wright" Subject: Re: [patch 07/76] NIU: Bump driver version and release date. Cc: linux-kernel@vger.kernel.org, stable@kernel.org, "Justin Forbes" , "Zwane Mwaikambo" , "Theodore Ts'o" , "Randy Dunlap" , "Dave Jones" , "Chuck Wolber" , "Chris Wedgwood" , "Michael Krufky" , "Chuck Ebbert" , "Domenico Andreoli" , torvalds@linux-foundation.org, akpm@linux-foundation.org, alan@lxorguk.ukuu.org.uk, "David S. Miller" , "Greg Kroah-Hartman" In-Reply-To: <20080321224333.400857992@sous-sol.org> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <20080321224250.144333319@sous-sol.org> <20080321224333.400857992@sous-sol.org> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1850 Lines: 55 On 21/03/2008, Chris Wright wrote: > -stable review patch. If anyone has any objections, please let us know. > --------------------- > I don't see how this one fits this criteria from Documentation/stable_kernel_rules.txt : ... - It must fix a real bug that bothers people (not a, "This could be a problem..." type thing). ... As I see it, this patch is quite trivial and does not fix any "real problem". How come this is suitable for -stable? I have no objections to the patch "as such", I just don't think it makes sense for -stable. > From: David S. Miller > > Upstream commit: a442585952f137bd4cdb1f2f3166e4157d383b82 > > Signed-off-by: David S. Miller > Signed-off-by: Greg Kroah-Hartman > Signed-off-by: Chris Wright > > --- > drivers/net/niu.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > --- a/drivers/net/niu.c > +++ b/drivers/net/niu.c > @@ -33,8 +33,8 @@ > > #define DRV_MODULE_NAME "niu" > #define PFX DRV_MODULE_NAME ": " > -#define DRV_MODULE_VERSION "0.6" > -#define DRV_MODULE_RELDATE "January 5, 2008" > +#define DRV_MODULE_VERSION "0.7" > +#define DRV_MODULE_RELDATE "February 18, 2008" > > static char version[] __devinitdata = > DRV_MODULE_NAME ".c:v" DRV_MODULE_VERSION " (" DRV_MODULE_RELDATE ")\n"; > -- Jesper Juhl Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html Plain text mails only, please http://www.expita.com/nomime.html -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/