Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756304AbYCVScu (ORCPT ); Sat, 22 Mar 2008 14:32:50 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756800AbYCVScf (ORCPT ); Sat, 22 Mar 2008 14:32:35 -0400 Received: from lazybastard.de ([212.112.238.170]:53926 "EHLO longford.logfs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754861AbYCVSce (ORCPT ); Sat, 22 Mar 2008 14:32:34 -0400 Date: Sat, 22 Mar 2008 19:32:00 +0100 From: =?utf-8?B?SsO2cm4=?= Engel To: Adrian McMenamin Cc: dwmw2 , Andrew Morton , linux-sh , Greg KH , Paul Mundt , LKML , MTD Subject: Re: [PATCH] 2/3 mtd: add support for flash on the SEGA Dreamcast Visual Memory Unit Message-ID: <20080322183200.GD19347@logfs.org> References: <1206207805.6324.13.camel@localhost.localdomain> <1206209035.6324.29.camel@localhost.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1206209035.6324.29.camel@localhost.localdomain> User-Agent: Mutt/1.5.13 (2006-08-11) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1472 Lines: 38 On Sat, 22 March 2008 18:03:55 +0000, Adrian McMenamin wrote: > > The SEGA Visual Memory Unit includes 128k of flash memory > which can be read in blocks. > > The hardware specification is also capable of supporting > partitions (though it is doubtful such devices exist). > > This driver supports block reads and writes, as well as > queries of hardware capabilities, through the maple > bus susbsystem. > > (It also implements a caching system so that, for instance, a > read of 60 bytes will take 1/60th - or 1/50th in PAL regions - > of a second instead of a second or 1.2 seconds.) Without a doubt, buffering is useful. However I question how useful it is to implement this in individual device drivers instead of once in mtd_core.c. > Signed-off-by: Adrian McMenamin Given that you have ignored most of my previous comments, NAK. I don't mind merging code that isn't up to our standards yet. But I have a bad feeling about a maintainer that does not understand review comments. Since you had similar problems understanding Andrew, part of the blame may sit on your side. Jörn -- The key to performance is elegance, not battalions of special cases. -- Jon Bentley and Doug McIlroy -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/