Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754235AbYCVUD2 (ORCPT ); Sat, 22 Mar 2008 16:03:28 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751281AbYCVUDU (ORCPT ); Sat, 22 Mar 2008 16:03:20 -0400 Received: from mx2.mail.elte.hu ([157.181.151.9]:34750 "EHLO mx2.mail.elte.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751191AbYCVUDT (ORCPT ); Sat, 22 Mar 2008 16:03:19 -0400 Date: Sat, 22 Mar 2008 21:02:51 +0100 From: Ingo Molnar To: Ravikiran G Thirumalai Cc: Yinghai Lu , Andrew Morton , linux-kernel@vger.kernel.org, Glauber de Oliveira Costa , shai@scalex86.org Subject: Re: [patch 4/4] x86: apic_is_clustered_box to indicate unsynched TSC's on multiboard vSMP systems Message-ID: <20080322200251.GB5508@elte.hu> References: <20080320073740.GA9414@localdomain> <20080320074508.GE9414@localdomain> <86802c440803200053m1b0928a9q6567d8c619fa7a2f@mail.gmail.com> <20080320190240.GB6085@localdomain> <20080321091542.GE20420@elte.hu> <20080321185225.GA23139@localdomain> <20080321185821.GE6571@elte.hu> <20080322185948.GD23139@localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20080322185948.GD23139@localdomain> User-Agent: Mutt/1.5.17 (2007-11-01) X-ELTE-VirusStatus: clean X-ELTE-SpamScore: -1.5 X-ELTE-SpamLevel: X-ELTE-SpamCheck: no X-ELTE-SpamVersion: ELTE 2.0 X-ELTE-SpamCheck-Details: score=-1.5 required=5.9 tests=BAYES_00 autolearn=no SpamAssassin version=3.2.3 -1.5 BAYES_00 BODY: Bayesian spam probability is 0 to 1% [score: 0.0006] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 610 Lines: 27 * Ravikiran G Thirumalai wrote: > OK. Something like this? yeah. small nit: > +int is_vsmp_box(void) > +{ > + if (is_vsmp != -1) > + return is_vsmp; > + else { > + printk("ScaleMP vSMPowered system detection called too early!\n"); > + return 0; > + } > } since this is an "impossible" scenario, just stick in a WARN_ON_ONCE(). Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/