Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761127AbYCXOnx (ORCPT ); Mon, 24 Mar 2008 10:43:53 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1759333AbYCXOnp (ORCPT ); Mon, 24 Mar 2008 10:43:45 -0400 Received: from mk-filter-1-a-1.mail.uk.tiscali.com ([212.74.100.52]:48178 "EHLO mk-filter-1-a-1.mail.uk.tiscali.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757418AbYCXOno (ORCPT ); Mon, 24 Mar 2008 10:43:44 -0400 X-Trace: 682417905/mk-filter-1.mail.uk.tiscali.com/B2C/$THROTTLED-DYNAMIC/CUSTOMER-DYNAMIC-IP/81.1.89.66 X-SBRS: None X-RemoteIP: 81.1.89.66 X-IP-MAIL-FROM: adrian@newgolddream.dyndns.info X-IP-BHB: Once X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AhUHAFpa50dRAVlC/2dsb2JhbACBW6VX Subject: Re: [PATCH] 2/3 mtd: add support for flash on the SEGA Dreamcast Visual Memory Unit From: Adrian McMenamin To: =?ISO-8859-1?Q?J=F6rn?= Engel , Andrew Morton Cc: Paul Mundt , linux-sh , LKML , MTD In-Reply-To: <20080324141043.GB2899@logfs.org> References: <1206211147.6324.48.camel@localhost.localdomain> <20080322185600.GE19347@logfs.org> <1206207805.6324.13.camel@localhost.localdomain> <1206209035.6324.29.camel@localhost.localdomain> <20080322183200.GD19347@logfs.org> <1206211147.6324.48.camel@localhost.localdomain> <20080324020832.GA13935@linux-sh.org> <1206360384.6283.11.camel@localhost.localdomain> <20080324132101.GA2899@logfs.org> <1206367120.6283.15.camel@localhost.localdomain> <20080324141043.GB2899@logfs.org> Content-Type: text/plain; charset=UTF-8 Date: Mon, 24 Mar 2008 14:43:16 +0000 Message-Id: <1206369796.6283.19.camel@localhost.localdomain> Mime-Version: 1.0 X-Mailer: Evolution 2.12.1 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1339 Lines: 32 On Mon, 2008-03-24 at 15:10 +0100, Jörn Engel wrote: > On Mon, 24 March 2008 13:58:40 +0000, Adrian McMenamin wrote: > > > > Tempting as it is to continue the war, discretion will be the better > > part of valour here and I will give you the last word. > > > > Of course I don't mind you sending patches. Indeed it would be very > > helpful and generous of you to do so. > > Good. The first four shouldn't change any behaviour. Number five flips > positive error returns into negative ones. I believe the old behaviour > is a bug. Worth a second look to make sure. > > All five patches are attached. Hope that doesn't cause any problems. > Well, I haven't got round to applying them and testing them yet, though they look ok, obviously, except for one thing: I'm pretty much where you are on the goto versus return thing, but got pretty clear instructions on a previous patch from Andrew Morton that using gotos to ensure functions limit the number of return points is the way to go. I've added him back in now we aren't exchanging flames, so maybe he can pronouce ex cathedra. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/