Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760778AbYCXOrN (ORCPT ); Mon, 24 Mar 2008 10:47:13 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1759332AbYCXOrE (ORCPT ); Mon, 24 Mar 2008 10:47:04 -0400 Received: from mta23.gyao.ne.jp ([125.63.38.249]:11830 "EHLO mx.gate01.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1756296AbYCXOrD (ORCPT ); Mon, 24 Mar 2008 10:47:03 -0400 Date: Mon, 24 Mar 2008 23:46:31 +0900 From: Paul Mundt To: Adrian McMenamin Cc: J?rn Engel , Andrew Morton , linux-sh , LKML , MTD Subject: Re: [PATCH] 2/3 mtd: add support for flash on the SEGA Dreamcast Visual Memory Unit Message-ID: <20080324144630.GA23826@linux-sh.org> Mail-Followup-To: Paul Mundt , Adrian McMenamin , J?rn Engel , Andrew Morton , linux-sh , LKML , MTD References: <1206207805.6324.13.camel@localhost.localdomain> <1206209035.6324.29.camel@localhost.localdomain> <20080322183200.GD19347@logfs.org> <1206211147.6324.48.camel@localhost.localdomain> <20080324020832.GA13935@linux-sh.org> <1206360384.6283.11.camel@localhost.localdomain> <20080324132101.GA2899@logfs.org> <1206367120.6283.15.camel@localhost.localdomain> <20080324141043.GB2899@logfs.org> <1206369796.6283.19.camel@localhost.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1206369796.6283.19.camel@localhost.localdomain> User-Agent: Mutt/1.5.13 (2006-08-11) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1610 Lines: 31 On Mon, Mar 24, 2008 at 02:43:16PM +0000, Adrian McMenamin wrote: > On Mon, 2008-03-24 at 15:10 +0100, J??rn Engel wrote: > > On Mon, 24 March 2008 13:58:40 +0000, Adrian McMenamin wrote: > > > > > > Tempting as it is to continue the war, discretion will be the better > > > part of valour here and I will give you the last word. > > > > > > Of course I don't mind you sending patches. Indeed it would be very > > > helpful and generous of you to do so. > > > > Good. The first four shouldn't change any behaviour. Number five flips > > positive error returns into negative ones. I believe the old behaviour > > is a bug. Worth a second look to make sure. > > > > All five patches are attached. Hope that doesn't cause any problems. > > Well, I haven't got round to applying them and testing them yet, though > they look ok, obviously, except for one thing: I'm pretty much where you > are on the goto versus return thing, but got pretty clear instructions > on a previous patch from Andrew Morton that using gotos to ensure > functions limit the number of return points is the way to go. > The gotos help clean up the error path when you have something to do. In this case there's nothing going on but a NULL return, so it really doesn't matter one way or the other. Most people tend to avoid the goto if you really have nothing to do in an error path. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/