Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757797AbYCXPxK (ORCPT ); Mon, 24 Mar 2008 11:53:10 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751692AbYCXPw4 (ORCPT ); Mon, 24 Mar 2008 11:52:56 -0400 Received: from 136-022.dsl.labridge.com ([206.117.136.22]:4080 "EHLO mail.perches.com" rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1752274AbYCXPw4 (ORCPT ); Mon, 24 Mar 2008 11:52:56 -0400 Subject: Re: [PATCH] drivers/net/wan/wanxl.c: time_before(timeout, jiffies) -> jiffies, timeout From: Joe Perches To: Krzysztof Halasa Cc: Roel Kluin <12o3l@tiscali.nl>, lkml In-Reply-To: References: <47E28637.4010700@tiscali.nl> <1206031566.26345.63.camel@localhost> Content-Type: text/plain Date: Mon, 24 Mar 2008 08:52:21 -0700 Message-Id: <1206373941.4845.21.camel@localhost> Mime-Version: 1.0 X-Mailer: Evolution 2.12.3-1.2mdv2008.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 540 Lines: 15 On Mon, 2008-03-24 at 16:01 +0100, Krzysztof Halasa wrote: > Joe Perches writes: > > Wouldn't it be better to have a schedule() in those > > while loops too? > There is a schedule() here: What's the value of not having schedule() in the wanxl_open and wanxl_close routines? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/