DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=beta;
        h=message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references;
        b=mMoHqY1FCvxSRIbylUbplxjtZn6GFlh+rM4OWNaYY7CwANVce+lFXvorjxe5yb1nZ2SsuvMx2Xr4/XpzovTkD/Lsh6c2T+QyOezS0tTrDrO/qigPaHgqG1xputHdcLjNZq8F6tcDTnAGx1tsLcvrYK5u5dg+G8AL+X8X4laiIK8=
Message-ID: <4cefeab80803241039n829edeexa141089c40a08a57@mail.gmail.com>
Date: Mon, 24 Mar 2008 23:09:33 +0530
From: "Nitin Gupta" <nitingupta910@gmail.com>
To: "Mariusz Kozlowski" <m.kozlowski@tuxland.pl>
Subject: Re: [PATCH 2/6] compcache: block device - internal defs
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org
In-Reply-To: <200803241725.59726.m.kozlowski@tuxland.pl>
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
References: <200803242033.30782.nitingupta910@gmail.com>
	 <200803241725.59726.m.kozlowski@tuxland.pl>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 735
Lines: 34

On Mon, Mar 24, 2008 at 9:55 PM, Mariusz Kozlowski
<m.kozlowski@tuxland.pl> wrote:
> Hi Nitin,
>
>
>  >  +#define K(x)   ((x) >> 10)
>  >  +#define KB(x)  ((x) << 10)
>
>  Hm. These look cryptic unless you remember what they do.
>  Could have better names?

I'll give them better names/add comments.

>
>
>  > +#define CC_DEBUG2((fmt,arg...) \
>  > +       printk(KERN_DEBUG C fmt,##arg)
>
>  Unbalanced parenthesis.
>

Corrected. Thanks.

- Nitin

>  Just my 0.05zl.
>
>         Mariusz
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/