Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755050AbYCXWiz (ORCPT ); Mon, 24 Mar 2008 18:38:55 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753310AbYCXWis (ORCPT ); Mon, 24 Mar 2008 18:38:48 -0400 Received: from gprs189-60.eurotel.cz ([160.218.189.60]:53190 "EHLO gprs189-60.eurotel.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751190AbYCXWir (ORCPT ); Mon, 24 Mar 2008 18:38:47 -0400 Date: Mon, 24 Mar 2008 23:39:25 +0100 From: Pavel Machek To: Oleg Nesterov Cc: Andrew Morton , "Eric W. Biederman" , Pavel Emelyanov , Stephen Smalley , Roland McGrath , linux-kernel@vger.kernel.org Subject: Re: [PATCH] ptrace: it is fun to strace /sbin/init Message-ID: <20080324223925.GD2426@elf.ucw.cz> References: <20080323135110.GA294@tv-sign.ru> <20080324160102.GB4069@atrey.karlin.mff.cuni.cz> <20080324164059.GA4767@tv-sign.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20080324164059.GA4767@tv-sign.ru> X-Warning: Reading this can be dangerous to your mental health. User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1409 Lines: 38 > > > @@ -803,6 +803,8 @@ and is between 256 and 4096 characters. > > > Run specified binary instead of /sbin/init as init > > > process. > > > > > > + init_ptrace [KNL] Allows to ptrace init. > > > + > > > > No words about it being dangerous, but I believe it is. > > it is, admin should know what he does, > > > If it is not, lets do the patch, but not optional. > > This will change the default historical behaviour, I can't predict > does this matter for (say) SELinux or not. Otherwise I'd personally > prefer to always allow to ptrace init. > > > If it is dangerous, option does not make it better. > > ptrace() is always dangerous. ptracer can crash oracle and lose data. > > /sbin/init is important, but there are other important (and sometimes > much more important) services. Why it is so special so that we can't > debug/strace it? Maybe. Let's kill /sbin/init protection in 2.6.26. But making it optional is wrong. Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html pomozte zachranit klanovicky les: http://www.ujezdskystrom.info/ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/