Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757557AbYCYDbw (ORCPT ); Mon, 24 Mar 2008 23:31:52 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1757216AbYCYDb3 (ORCPT ); Mon, 24 Mar 2008 23:31:29 -0400 Received: from g5t0007.atlanta.hp.com ([15.192.0.44]:24344 "EHLO g5t0007.atlanta.hp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757193AbYCYDb1 (ORCPT ); Mon, 24 Mar 2008 23:31:27 -0400 Date: Mon, 24 Mar 2008 21:31:27 -0600 From: Alex Chiang To: Kenji Kaneshige Cc: Greg KH , Gary Hade , Kristen Carlson Accardi , Matthew Wilcox , warthog19@eaglescrag.net, rick.jones2@hp.com, linux-kernel@vger.kernel.org, linux-pci@atrey.karlin.mff.cuni.cz, linux-acpi@vger.kernel.org Subject: Re: [PATCH 14/16] PCI slot: Change return value of pci_destroy_slot() (Not for mainline!) Message-ID: <20080325033127.GC26434@ldl.fc.hp.com> Mail-Followup-To: Alex Chiang , Kenji Kaneshige , Greg KH , Gary Hade , Kristen Carlson Accardi , Matthew Wilcox , warthog19@eaglescrag.net, rick.jones2@hp.com, linux-kernel@vger.kernel.org, linux-pci@atrey.karlin.mff.cuni.cz, linux-acpi@vger.kernel.org References: <20080318210539.GA30421@ldl.fc.hp.com> <47E33472.1000602@jp.fujitsu.com> <47E338E5.3020504@jp.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <47E338E5.3020504@jp.fujitsu.com> User-Agent: Mutt/1.5.16 (2007-06-09) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2061 Lines: 58 * Kenji Kaneshige : > Since nobody checks the return value from pci_destroy_slot(), it > should be void. Thanks, merged. /ac > > Signed-off-by: Kenji Kaneshige > > --- > drivers/pci/slot.c | 4 +--- > include/linux/pci.h | 2 +- > 2 files changed, 2 insertions(+), 4 deletions(-) > > Index: linux-2.6.25-rc6/drivers/pci/slot.c > =================================================================== > --- linux-2.6.25-rc6.orig/drivers/pci/slot.c > +++ linux-2.6.25-rc6/drivers/pci/slot.c > @@ -118,7 +118,7 @@ struct pci_slot *pci_create_slot(struct > } > EXPORT_SYMBOL_GPL(pci_create_slot); > > -int pci_destroy_slot(struct pci_slot *slot) > +void pci_destroy_slot(struct pci_slot *slot) > { > pr_debug("%s: decreased refcount to %d on %x:%d\n", __func__, > atomic_read(&slot->kobj.kref.refcount) - 1, slot->bus->number, > @@ -127,8 +127,6 @@ int pci_destroy_slot(struct pci_slot *sl > down_write(&pci_bus_sem); > kobject_put(&slot->kobj); > up_write(&pci_bus_sem); > - > - return 0; > } > EXPORT_SYMBOL_GPL(pci_destroy_slot); > > Index: linux-2.6.25-rc6/include/linux/pci.h > =================================================================== > --- linux-2.6.25-rc6.orig/include/linux/pci.h > +++ linux-2.6.25-rc6/include/linux/pci.h > @@ -493,7 +493,7 @@ struct pci_bus *pci_add_new_bus(struct p > int busnr); > struct pci_slot *pci_create_slot(struct pci_bus *parent, int slot_nr, > const char *name); > -int pci_destroy_slot(struct pci_slot *slot); > +void pci_destroy_slot(struct pci_slot *slot); > int pci_scan_slot(struct pci_bus *bus, int devfn); > struct pci_dev *pci_scan_single_device(struct pci_bus *bus, int devfn); > void pci_device_add(struct pci_dev *dev, struct pci_bus *bus); > > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/