Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757346AbYCYDbi (ORCPT ); Mon, 24 Mar 2008 23:31:38 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1757010AbYCYDbV (ORCPT ); Mon, 24 Mar 2008 23:31:21 -0400 Received: from g5t0006.atlanta.hp.com ([15.192.0.43]:37829 "EHLO g5t0006.atlanta.hp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756964AbYCYDbU (ORCPT ); Mon, 24 Mar 2008 23:31:20 -0400 Date: Mon, 24 Mar 2008 21:31:18 -0600 From: Alex Chiang To: Kenji Kaneshige Cc: Greg KH , Gary Hade , Kristen Carlson Accardi , Matthew Wilcox , warthog19@eaglescrag.net, rick.jones2@hp.com, linux-kernel@vger.kernel.org, linux-pci@atrey.karlin.mff.cuni.cz, linux-acpi@vger.kernel.org Subject: Re: [PATCH 13/16] PCI slot: Fix return value of pci_create_slot() (Not for mainline!) Message-ID: <20080325033118.GB26434@ldl.fc.hp.com> Mail-Followup-To: Alex Chiang , Kenji Kaneshige , Greg KH , Gary Hade , Kristen Carlson Accardi , Matthew Wilcox , warthog19@eaglescrag.net, rick.jones2@hp.com, linux-kernel@vger.kernel.org, linux-pci@atrey.karlin.mff.cuni.cz, linux-acpi@vger.kernel.org References: <20080318210539.GA30421@ldl.fc.hp.com> <47E33472.1000602@jp.fujitsu.com> <47E33833.9000408@jp.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <47E33833.9000408@jp.fujitsu.com> User-Agent: Mutt/1.5.16 (2007-06-09) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 948 Lines: 33 * Kenji Kaneshige : > We can use the error code from kobject_init_and_add() as it is. Thanks, merged. /ac > > Signed-off-by: Kenji Kaneshige > > --- > drivers/pci/slot.c | 1 - > 1 file changed, 1 deletion(-) > > Index: linux-2.6.25-rc6/drivers/pci/slot.c > =================================================================== > --- linux-2.6.25-rc6.orig/drivers/pci/slot.c > +++ linux-2.6.25-rc6/drivers/pci/slot.c > @@ -99,7 +99,6 @@ struct pci_slot *pci_create_slot(struct > "%s", name); > if (err) { > printk(KERN_ERR "Unable to register kobject %s\n", name); > - err = -EINVAL; > goto err; > } > > > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/