Message-ID: <47E88381.6030705@zytor.com>
Date: Mon, 24 Mar 2008 21:45:53 -0700
From: "H. Peter Anvin" <hpa@zytor.com>
User-Agent: Thunderbird 2.0.0.12 (X11/20080226)
MIME-Version: 1.0
To: Yinghai Lu <yhlu.kernel@gmail.com>
CC: Ingo Molnar <mingo@elte.hu>, Thomas Gleixner <tglx@linutronix.de>,
       Andrew Morton <akpm@linux-foundation.org>,
       kernel list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] x86: enable PAT for amd k8 and fam10h
References: <200803241602.01957.yhlu.kernel@gmail.com>	 <47E85593.4030104@zytor.com> <86802c440803241922u50fb33f8xb33118e22c2f7ad2@mail.gmail.com>
In-Reply-To: <86802c440803241922u50fb33f8xb33118e22c2f7ad2@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1076
Lines: 31

Yinghai Lu wrote:
>>
>>  This really should be handled through a CPU flag.  Specifically, it
>>  should be handled by disabling the PAT flag if PAT is unusable or
>>  suspect of being unusable; it should *NOT* be stashed away in a
>>  completely separate piece of code.
> 
> PAT patches in x86.git latest, only support some intel CPUs.
> 
>         if (boot_cpu_data.x86_vendor == X86_VENDOR_INTEL &&
>             (boot_cpu_data.x86 == 0xF ||
>              (boot_cpu_data.x86 == 6 && boot_cpu_data.x86_model >= 15))) {
>                 if (cpu_has_pat) {
>                         return 1;
>                 }
>         }
> 
> should be moved to setup_64.c?
> 

Yes, which in turn should be merged with the 32-bit code in cpu/*.c.

Personally I would prefer a blacklist rather than a whitelist, but 
that's nitpicking.

	-=hpa
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/