Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754107AbYCYKsu (ORCPT ); Tue, 25 Mar 2008 06:48:50 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753115AbYCYKsm (ORCPT ); Tue, 25 Mar 2008 06:48:42 -0400 Received: from 81-174-11-161.static.ngi.it ([81.174.11.161]:55531 "EHLO mail.enneenne.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753015AbYCYKsl (ORCPT ); Tue, 25 Mar 2008 06:48:41 -0400 Date: Tue, 25 Mar 2008 11:48:31 +0100 From: Rodolfo Giometti To: Kay Sievers Cc: linux-kernel@vger.kernel.org, Andrew Morton , David Woodhouse , Dave Jones , Sam Ravnborg , Greg KH , Randy Dunlap Message-ID: <20080325104831.GE8959@enneenne.com> References: <12048053463198-git-send-email-giometti@linux.it> <12048053473401-git-send-email-giometti@linux.it> <3ae72650803202036i7aee418et23b1ec5ac72560f7@mail.gmail.com> <20080321105649.GA8959@enneenne.com> <1206118805.24338.7.camel@lov.site> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1206118805.24338.7.camel@lov.site> Organization: GNU/Linux Device Drivers, Embedded Systems and Courses X-PGP-Key: gpg --keyserver keyserver.linux.it --recv-keys D25A5633 User-Agent: Mutt/1.5.16 (2007-06-11) X-SA-Exim-Connect-IP: 192.168.32.1 X-SA-Exim-Mail-From: giometti@enneenne.com Subject: Re: [PATCH 1/7] LinuxPPS core support. X-SA-Exim-Version: 4.2.1 (built Tue, 09 Jan 2007 17:23:22 +0000) X-SA-Exim-Scanned: Yes (on mail.enneenne.com) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2279 Lines: 59 On Fri, Mar 21, 2008 at 06:00:05PM +0100, Kay Sievers wrote: > On Fri, 2008-03-21 at 11:56 +0100, Rodolfo Giometti wrote: > > On Fri, Mar 21, 2008 at 04:36:44AM +0100, Kay Sievers wrote: > > > On Thu, Mar 6, 2008 at 1:09 PM, Rodolfo Giometti wrote: > > > > This patch adds the kernel side of the PPS support currently named > > > > "LinuxPPS". > > > > > > > diff --git a/drivers/pps/sysfs.c b/drivers/pps/sysfs.c > > > > new file mode 100644 > > > > index 0000000..c25c91c > > > > --- /dev/null > > > > +++ b/drivers/pps/sysfs.c > > > > @@ -0,0 +1,130 @@ > > > > > > > +void pps_sysfs_remove_source_entry(struct pps_device *pps) > > > > +{ > > > > + /* Delete info files */ > > > > + sysfs_remove_group(&pps->dev->kobj, &pps_group); > > > > +} > > > > + > > > > +int pps_sysfs_create_source_entry(struct pps_device *pps) > > > > +{ > > > > + int ret; > > > > + > > > > + /* Create info files */ > > > > + ret = sysfs_create_group(&pps->dev->kobj, &pps_group); > > > > > > Any specific reason you are creating the group by hand, and not assign > > > it to the default group in your class? It would will let the core > > > handle it for you. The device add uevent to userspace will happen > > > before you added the attributes, which is usually not nice. > > > > No any specific reason... I just supposed it was the-right-think(TM)! > > :) > > > > Can you please suggest me an URL where I can see how to rework the > > code? > > You can assign class->dev_attrs the array of attributes, and the driver > core will create these attributes for all devices that get registered > with that class. See: drivers/base/core.c :: device_add_attrs(). Fixed, I'll provide a new patch ASAP. Thanks, Rodolfo -- GNU/Linux Solutions e-mail: giometti@enneenne.com Linux Device Driver giometti@gnudd.com Embedded Systems giometti@linux.it UNIX programming phone: +39 349 2432127 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/