Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757957AbYCYQC3 (ORCPT ); Tue, 25 Mar 2008 12:02:29 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755908AbYCYQCW (ORCPT ); Tue, 25 Mar 2008 12:02:22 -0400 Received: from mga03.intel.com ([143.182.124.21]:2772 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753025AbYCYQCV convert rfc822-to-8bit (ORCPT ); Tue, 25 Mar 2008 12:02:21 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.25,552,1199692800"; d="scan'208";a="222975068" X-MimeOLE: Produced By Microsoft Exchange V6.5 Content-class: urn:content-classes:message MIME-Version: 1.0 Subject: RE: [patch 51/76] ioat: fix ack handling, driver must ensure that ack is zero Date: Tue, 25 Mar 2008 15:55:23 -0000 Message-ID: <7F38996F7185A24AB9071ED4950AD8C101536C72@swsmsx413.ger.corp.intel.com> In-Reply-To: X-MS-Has-Attach: X-MS-TNEF-Correlator: Thread-Topic: [patch 51/76] ioat: fix ack handling, driver must ensure that ack is zero Thread-Index: AciOjdHs6TsXT220T3+uc3Oq3jZw8wAALUyw From: "Sosnowski, Maciej" To: , , Cc: , , , , , , , , , , , , , "Williams, Dan J" , "Nelson, Shannon" , X-OriginalArrivalTime: 25 Mar 2008 15:55:24.0617 (UTC) FILETIME=[A34C2390:01C88E90] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2957 Lines: 83 > ---------- Original message ---------- > From: Chris Wright > Date: Mar 21, 2008 11:43 PM > Subject: [patch 51/76] ioat: fix ack handling, driver must ensure that > ack is zero > To: linux-kernel@vger.kernel.org, stable@kernel.org, jejb@kernel.org > Cc: Justin Forbes , Zwane Mwaikambo > , Theodore Ts'o , Randy Dunlap > , Dave Jones , Chuck Wolber > , Chris Wedgwood , > Michael Krufky , Chuck Ebbert > , Domenico Andreoli , > torvalds@linux-foundation.org, akpm@linux-foundation.org, > alan@lxorguk.ukuu.org.uk, Dan Williams , > Shannon Nelson , Greg Kroah-Hartman > > > > -stable review patch. If anyone has any objections, please let us know. > --------------------- > > From: Dan Williams > > Initialize 'ack' to zero in case the descriptor has been recycled. > > Prevents "kernel BUG at crypto/async_tx/async_xor.c:185!" > > Signed-off-by: Dan Williams > Acked-by: Shannon Nelson > [chrisw@sous-sol.org: backport to 2.6.24.3] > Signed-off-by: Chris Wright > Signed-off-by: Greg Kroah-Hartman > --- > > drivers/dma/ioat_dma.c | 2 ++ > 1 file changed, 2 insertions(+) > > --- a/drivers/dma/ioat_dma.c > +++ b/drivers/dma/ioat_dma.c > @@ -726,6 +726,7 @@ static struct dma_async_tx_descriptor *i > > if (new) { > new->len = len; > + new->async_tx.ack = 0; > return &new->async_tx; > } else > return NULL; > @@ -749,6 +750,7 @@ static struct dma_async_tx_descriptor *i > > if (new) { > new->len = len; > + new->async_tx.ack = 0; > return &new->async_tx; > } else > return NULL; > > -- Acked-by: Maciej Sosnowski --------------------------------------------------------------------- Intel Technology Poland sp. z o.o. z siedziba w Gdansku ul. Slowackiego 173 80-298 Gdansk Sad Rejonowy Gdansk Polnoc w Gdansku, VII Wydzial Gospodarczy Krajowego Rejestru Sadowego, numer KRS 101882 NIP 957-07-52-316 Kapital zakladowy 200.000 zl This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). Any review or distribution by others is strictly prohibited. If you are not the intended recipient, please contact the sender and delete all copies. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/