Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759541AbYCYSEA (ORCPT ); Tue, 25 Mar 2008 14:04:00 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1759446AbYCYSDu (ORCPT ); Tue, 25 Mar 2008 14:03:50 -0400 Received: from one.firstfloor.org ([213.235.205.2]:47132 "EHLO one.firstfloor.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759440AbYCYSDt (ORCPT ); Tue, 25 Mar 2008 14:03:49 -0400 Date: Tue, 25 Mar 2008 19:07:00 +0100 From: Andi Kleen To: Christoph Lameter Cc: Andi Kleen , linux-mm@kvack.org, linux-kernel@vger.kernel.org, viro@ftp.linux.org.uk Subject: Re: [11/14] vcompound: Fallbacks for order 1 stack allocations on IA64 and x86 Message-ID: <20080325180700.GY2170@one.firstfloor.org> References: <20080321061703.921169367@sgi.com> <20080321061726.782068299@sgi.com> <871w63iuap.fsf@basil.nowhere.org> <20080325075106.GF2170@one.firstfloor.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.2.1i Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 818 Lines: 21 On Tue, Mar 25, 2008 at 10:55:06AM -0700, Christoph Lameter wrote: > On Tue, 25 Mar 2008, Andi Kleen wrote: > > > Maybe sparse could be taught to check for this if it happens > > in a single function? (cc'ing Al who might have some thoughts > > on this). Of course if it happens spread out over multiple > > functions sparse wouldn't help neither. > > We could add debugging code to virt_to_page (or __pa) to catch these uses. Hard to test all cases. Static checking would be better. Or just not do it? I didn't think order 1 failures were that big a problem. -Andi -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/