Date: Tue, 25 Mar 2008 12:14:38 -0700
From: Andrew Morton <akpm@linux-foundation.org>
To: "Robert P. J. Day" <rpjday@crashcourse.ca>
Cc: andi@firstfloor.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] RWSEM: Rewrite rwsem.c and rwsem-spinlock.c more
 simply.
Message-Id: <20080325121438.883f7ceb.akpm@linux-foundation.org>
In-Reply-To: <alpine.LFD.1.00.0803250834220.19530@localhost.localdomain>
References: <alpine.LFD.1.00.0803250659530.18358@localhost.localdomain>
	<87skyfgg4y.fsf@basil.nowhere.org>
	<alpine.LFD.1.00.0803250813190.19386@localhost.localdomain>
	<20080325123633.GL2170@one.firstfloor.org>
	<alpine.LFD.1.00.0803250834220.19530@localhost.localdomain>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1141
Lines: 28

On Tue, 25 Mar 2008 08:42:48 -0400 (EDT)
"Robert P. J. Day" <rpjday@crashcourse.ca> wrote:

> On Tue, 25 Mar 2008, Andi Kleen wrote:
> 
> > > i'm not sure what this means -- which of the transformations in
> > > that patch is considered unsafe?  here's a typical simplification:
> >
> > It is not unsafe, just generates slight worse code.
> >
> > current is inline assembler and the compiler doesn't know that it
> > could cache it in a register because it is not marked pure for
> > various reasons. That is why current is often cached explicitely in
> > a local variable to tell the compiler that.
> 
>   ah, i think i see, thanks.  learn something every day.

A crude measyure is /usr/bin/size.  Your patch increased rwsem-spinlock.o
from 1595 bytes of text up to 1629.

A text size increase isn't necessarily always a bad thing, but it does need
to be monitored, understood, explained, etc.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/