Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761799AbYCZBQ7 (ORCPT ); Tue, 25 Mar 2008 21:16:59 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1760727AbYCZBQl (ORCPT ); Tue, 25 Mar 2008 21:16:41 -0400 Received: from ug-out-1314.google.com ([66.249.92.169]:32188 "EHLO ug-out-1314.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1760713AbYCZBQk (ORCPT ); Tue, 25 Mar 2008 21:16:40 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=date:to:cc:subject:message-id:user-agent:mime-version:content-type:from; b=baZdR1xrh47c2Zmq2x6ruaOgrOXuIg2SpTAfVBEmxTc41OF1rffn3bTH1fboZ7IBC+SqFegN9+NDfx0QW62u1eV9vZmuPm+jIJ0A8Fj38ij1xCjEIKEDKm+YNbyJ0QAqc059xhuD6ZmVM2dyTsXwwI821GMYWYTLJjklVsAjmLk= Date: Wed, 26 Mar 2008 02:16:42 +0100 (CET) To: LKML cc: Kyle McMartin , Matthew Wilcox , Grant Grundler , linux-parisc@vger.kernel.org, Ian Molton , Alain L Knaff , David C Niemi , Trivial Patch Monkey , Andrew Morton Subject: [PATCH] parisc floppy: kill the 'register' keyword from header Message-ID: User-Agent: Alpine 1.00 (LNX 882 2007-12-20) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII From: Jesper Juhl Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1521 Lines: 49 When compilers became generally better at optimizing code than humans, the register keyword became mostly useless. For the floppy driver it certainly is since it's so slow compared to the rest of the system that optimizing access to a single variable or two isn't going to make any real difference So let's just leave it to the compiler - it'll do a better job anyway. This patch does away with a few register keywords in the parisc floppy driver. Signed-off-by: Jesper Juhl --- floppy.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/include/asm-parisc/floppy.h b/include/asm-parisc/floppy.h index 4ca69f5..2f0a371 100644 --- a/include/asm-parisc/floppy.h +++ b/include/asm-parisc/floppy.h @@ -64,7 +64,7 @@ static int doing_pdma=0; static void floppy_hardint(int irq, void *dev_id, struct pt_regs * regs) { - register unsigned char st; + unsigned char st; #undef TRACE_FLPY_INT @@ -84,8 +84,8 @@ static void floppy_hardint(int irq, void *dev_id, struct pt_regs * regs) #endif { - register int lcount; - register char *lptr = virtual_dma_addr; + int lcount; + char *lptr = virtual_dma_addr; for (lcount = virtual_dma_count; lcount; lcount--) { st = fd_inb(virtual_dma_port+4) & 0xa0 ; -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/