Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761991AbYCZBRV (ORCPT ); Tue, 25 Mar 2008 21:17:21 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1761891AbYCZBRD (ORCPT ); Tue, 25 Mar 2008 21:17:03 -0400 Received: from ug-out-1314.google.com ([66.249.92.171]:32669 "EHLO ug-out-1314.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1761823AbYCZBRA (ORCPT ); Tue, 25 Mar 2008 21:17:00 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=date:to:cc:subject:message-id:user-agent:mime-version:content-type:from; b=DL1rWDyhZetHKyrt742IghZEg2YwFoQoAKiEILgNvKFiQOq+SoJPzWC0nis71F3eOK2YVzawVgOBqWNSgMKNcBgMZmqzcM6lPkX9DGJ7s2DWSPe63dKToaY5+0OKFCDe7jNIRgQCvgDXEkaXYETlSiw0yLalessb3A8N4J44xo4= Date: Wed, 26 Mar 2008 02:17:03 +0100 (CET) To: LKML cc: Geert Uytterhoeven , Roman Zippel , linux-m68k@vger.kernel.org, Ian Molton , Alain L Knaff , David C Niemi , Trivial Patch Monkey , Andrew Morton Subject: [PATCH] m68k floppy: kill 'register' keyword from header Message-ID: User-Agent: Alpine 1.00 (LNX 882 2007-12-20) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII From: Jesper Juhl Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1418 Lines: 48 When compilers became generally better at optimizing code than humans, the register keyword became mostly useless. For the floppy driver it certainly is since it's so slow compared to the rest of the system that optimizing access to a single variable or two isn't going to make any real difference So let's just leave it to the compiler - it'll do a better job anyway. This patch does away with a few register keywords in the m68k floppy driver. Signed-off-by: Jesper Juhl --- floppy.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/include/asm-m68k/floppy.h b/include/asm-m68k/floppy.h index 697d503..18efe25 100644 --- a/include/asm-m68k/floppy.h +++ b/include/asm-m68k/floppy.h @@ -182,7 +182,7 @@ static void fd_disable_dma(void) asmlinkage irqreturn_t floppy_hardint(int irq, void *dev_id) { - register unsigned char st; + unsigned char st; #undef TRACE_FLPY_INT #define NO_FLOPPY_ASSEMBLER @@ -203,8 +203,8 @@ asmlinkage irqreturn_t floppy_hardint(int irq, void *dev_id) #endif { - register int lcount; - register char *lptr; + int lcount; + char *lptr; /* serve 1st byte fast: */ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/