Date: Tue, 25 Mar 2008 19:42:21 -0700 (PDT)
Message-Id: <20080325.194221.16658596.davem@davemloft.net>
To: jgarzik@pobox.com
Cc: yang.shi@windriver.com, netdev@vger.kernel.org,
       linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Improvev netconsole support for RTL8139 NIC driver
From: David Miller <davem@davemloft.net>
In-Reply-To: <47E9B39C.5010502@pobox.com>
References: <47E9B115.9060109@windriver.com>
	<47E9B39C.5010502@pobox.com>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 637
Lines: 17

From: Jeff Garzik <jgarzik@pobox.com>
Date: Tue, 25 Mar 2008 22:23:24 -0400

> This is bogus -- you should never need to slow down the hot path in such 
> a way.

Slow down in what way?  Even on x86 saving the flags is just
about as expensive as a plain sti/cli.

I would in fact prefer to see drivers unconditionally use
spin_lock_irqsave() et al. in the interrupt handler, for
consistency.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/