Date: Wed, 26 Mar 2008 10:03:36 +0000
From: Andy Whitcroft <apw@shadowen.org>
To: Dean Nelson <dcn@sgi.com>
Cc: rdunlap@xenotime.net, jschopp@austin.ibm.com, jes@sgi.com,
       linux-kernel@vger.kernel.org, tony.luck@intel.com,
       linux-ia64@vger.kernel.org
Subject: Re: [Patch 5/5] run drivers/misc/xp through scripts/checkpatch.pl
Message-ID: <20080326100336.GE22584@shadowen.org>
References: <20080325192524.343385569@attica.americas.sgi.com> <20080325192558.959273025@attica.americas.sgi.com> <20080325200517.GA4446@sgi.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20080325200517.GA4446@sgi.com>
User-Agent: Mutt/1.5.13 (2006-08-11)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1350
Lines: 36

On Tue, Mar 25, 2008 at 03:05:17PM -0500, Dean Nelson wrote:
> On Tue, Mar 25, 2008 at 02:25:29PM -0500, dcn@sgi.com wrote:
> > 
> > Addressed issues raised by scripts/checkpatch.pl. Removed unnecessary curly
> > braces.  Eliminated uses of volatiles and use of kernel_thread() and
> > daemonize().
> > 
> > Signed-off-by: Dean Nelson <dcn@sgi.com>
> > 
> 
> Forgot to mention that scripts/checkpatch.pl gave 15 false positives of
> the following type against drivers/misc/xp/xp_main.c.
> 
> > WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
> > #48: FILE: misc/xp/xp_main.c:48:
> > +EXPORT_SYMBOL_GPL(xp_remote_memcpy);
> 
> The fact is that the EXPORT_SYMBOL(xp_remote_memcpy) does immediately follow
> the function/variable as follows.
> 
> enum xp_retval (*xp_remote_memcpy) (void *dst, const void *src, size_t len);
> EXPORT_SYMBOL_GPL(xp_remote_memcpy);

Gah, who ever came up with that syntax.  Yep, thats a falsie.  Should be
fixed in the latest version:

  http://www.kernel.org/pub/linux/kernel/people/apw/checkpatch/checkpatch.pl-next

Thanks for the report.

-apw
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/