Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759429AbYCZLBV (ORCPT ); Wed, 26 Mar 2008 07:01:21 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755032AbYCZLBN (ORCPT ); Wed, 26 Mar 2008 07:01:13 -0400 Received: from mx2.mail.elte.hu ([157.181.151.9]:51004 "EHLO mx2.mail.elte.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753879AbYCZLBN (ORCPT ); Wed, 26 Mar 2008 07:01:13 -0400 Date: Wed, 26 Mar 2008 12:00:51 +0100 From: Ingo Molnar To: Al Viro Cc: J?rn Engel , David Miller , jirislaby@gmail.com, joe@perches.com, tglx@linutronix.de, linux-kernel@vger.kernel.org, Andy Whitcroft Subject: Re: [patch] bkl2mtd: cleanup Message-ID: <20080326110047.GD17176@elte.hu> References: <20080323.051929.267232495.davem@davemloft.net> <20080325104841.GA24211@elte.hu> <20080325111129.GB11359@logfs.org> <20080325122413.GA8729@elte.hu> <20080325131258.GC11359@logfs.org> <20080325133810.GA10044@elte.hu> <20080325134556.GA10424@elte.hu> <20080325160734.GA14583@logfs.org> <20080326101452.GA17176@elte.hu> <20080326104821.GS10722@ZenIV.linux.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20080326104821.GS10722@ZenIV.linux.org.uk> User-Agent: Mutt/1.5.17 (2007-11-01) X-ELTE-VirusStatus: clean X-ELTE-SpamScore: -1.5 X-ELTE-SpamLevel: X-ELTE-SpamCheck: no X-ELTE-SpamVersion: ELTE 2.0 X-ELTE-SpamCheck-Details: score=-1.5 required=5.9 tests=BAYES_00 autolearn=no SpamAssassin version=3.2.3 -1.5 BAYES_00 BODY: Bayesian spam probability is 0 to 1% [score: 0.0000] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1142 Lines: 38 * Al Viro wrote: > On Wed, Mar 26, 2008 at 11:14:52AM +0100, Ingo Molnar wrote: > > /* Info for the block device */ > > struct block2mtd_dev { > > - struct list_head list; > > - struct block_device *blkdev; > > - struct mtd_info mtd; > > - struct mutex write_mutex; > > + struct list_head list; > > + struct block_device *blkdev; > > + struct mtd_info mtd; > > + /* serializes writes with each other and also with erase: */ > > + struct mutex write_mutex; > > }; > > Why the hell? the vertical alignment? For the same reason some of the key VFS data structures in include/linux/fs.h are aligned vertically: struct inode struct file struct super_block struct address_space struct block_device there are several advantages of aligning structure fields vertically (and the same applies to bulk initializers of structures), should i list them? Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/