Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759629AbYCZLZ1 (ORCPT ); Wed, 26 Mar 2008 07:25:27 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753387AbYCZLZR (ORCPT ); Wed, 26 Mar 2008 07:25:17 -0400 Received: from 74-93-104-97-Washington.hfc.comcastbusiness.net ([74.93.104.97]:37532 "EHLO sunset.davemloft.net" rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1752796AbYCZLZQ (ORCPT ); Wed, 26 Mar 2008 07:25:16 -0400 Date: Wed, 26 Mar 2008 04:25:16 -0700 (PDT) Message-Id: <20080326.042516.261621639.davem@davemloft.net> To: m.kozlowski@tuxland.pl Cc: torvalds@linux-foundation.org, linux-kernel@vger.kernel.org, sparclinux@vger.kernel.org Subject: Re: sparc64 BUG: using smp_processor_id() in preemptible From: David Miller In-Reply-To: <20080326.041626.224135350.davem@davemloft.net> References: <200803261142.07422.m.kozlowski@tuxland.pl> <20080326.041626.224135350.davem@davemloft.net> X-Mailer: Mew version 5.2 on Emacs 22.1 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1279 Lines: 44 From: David Miller Date: Wed, 26 Mar 2008 04:16:26 -0700 (PDT) > From: Mariusz Kozlowski > Date: Wed, 26 Mar 2008 11:42:07 +0100 > > > I see lots of these messages on my ultra 60 box. > > This is a sparc64 bug. And this patch should fix it: commit 69072f6e8e4bd4799d2a54e4ff8771d0657512c1 Author: David S. Miller Date: Wed Mar 26 04:25:00 2008 -0700 [SPARC64]: Fix __get_cpu_var in preemption-enabled area. Reported by Mariusz Kozlowski. Signed-off-by: David S. Miller diff --git a/arch/sparc64/mm/tlb.c b/arch/sparc64/mm/tlb.c index 3f10fc9..a0f000b 100644 --- a/arch/sparc64/mm/tlb.c +++ b/arch/sparc64/mm/tlb.c @@ -23,10 +23,11 @@ DEFINE_PER_CPU(struct mmu_gather, mmu_gathers) = { 0, }; void flush_tlb_pending(void) { - struct mmu_gather *mp = &__get_cpu_var(mmu_gathers); + struct mmu_gather *mp; preempt_disable(); + mp = &__get_cpu_var(mmu_gathers); if (mp->tlb_nr) { flush_tsb_user(mp); -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/