Date: Wed, 26 Mar 2008 04:48:02 -0700 (PDT)
Message-Id: <20080326.044802.107678511.davem@davemloft.net>
To: joern@logfs.org
Cc: mingo@elte.hu, apw@shadowen.org, jirislaby@gmail.com,
       viro@ZenIV.linux.org.uk, joe@perches.com, tglx@linutronix.de,
       linux-kernel@vger.kernel.org
Subject: Re: [PATCH 109/148] include/asm-x86/serial.h: checkpatch cleanups
 - formatting only
From: David Miller <davem@davemloft.net>
In-Reply-To: <20080326114142.GD22847@logfs.org>
References: <20080326102654.GB22847@logfs.org>
	<20080326112311.GG17176@elte.hu>
	<20080326114142.GD22847@logfs.org>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=iso-8859-1
Content-Transfer-Encoding: 8BIT
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 727
Lines: 21

From: J?rn Engel <joern@logfs.org>
Date: Wed, 26 Mar 2008 12:41:42 +0100

> Do you have a non-consistency based reason to prefer the longer
> version?

Inconstent spacing fools people's eyes and leads to bugs,
more often than not.

After 15 years of kernel development, I can remember at
least 10 or so multi-week-debugging sessions that could
have been curtailed had I not mis-read a poorly spaced
C statement.

It matters in practical terms, not just consistency terms,
trust me.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/