From: Mariusz Kozlowski <m.kozlowski@tuxland.pl>
To: David Miller <davem@davemloft.net>
Subject: Re: sparc64 BUG: using smp_processor_id() in preemptible
Date: Wed, 26 Mar 2008 13:10:12 +0100
User-Agent: KMail/1.9.7
Cc: torvalds@linux-foundation.org, linux-kernel@vger.kernel.org,
       sparclinux@vger.kernel.org
References: <20080326.041626.224135350.davem@davemloft.net> <200803261246.53770.m.kozlowski@tuxland.pl> <20080326.045143.218956952.davem@davemloft.net>
In-Reply-To: <20080326.045143.218956952.davem@davemloft.net>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200803261310.12556.m.kozlowski@tuxland.pl>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1688
Lines: 55

Hello,

> From: Mariusz Kozlowski <m.kozlowski@tuxland.pl>
> Date: Wed, 26 Mar 2008 12:46:53 +0100
> 
> > Ok it worked. Now I get a bunch of these:
> > 
> > BUG: using smp_processor_id() in preemptible [00000000] code: pidof/2471
> > caller is flush_ptrace_access+0xc0/0x1a0
> 
> Here ya go:
> 
> commit f6a843d939ade435e060d580f5c56d958464f8a5
> Author: David S. Miller <davem@davemloft.net>
> Date:   Wed Mar 26 04:51:12 2008 -0700
> 
>     [SPARC64]: flush_ptrace_access() needs preemption disable.
>     
>     Based upon a report by Mariusz Kozlowski.
>     
>     Signed-off-by: David S. Miller <davem@davemloft.net>
> 
> diff --git a/arch/sparc64/kernel/ptrace.c b/arch/sparc64/kernel/ptrace.c
> index bcf58ec..aaae865 100644
> --- a/arch/sparc64/kernel/ptrace.c
> +++ b/arch/sparc64/kernel/ptrace.c
> @@ -70,6 +70,8 @@ void flush_ptrace_access(struct vm_area_struct *vma, struct page *page,
>  	if (tlb_type == hypervisor)
>  		return;
>  
> +	preempt_disable();
> +
>  #ifdef DCACHE_ALIASING_POSSIBLE
>  	/* If bit 13 of the kernel address we used to access the
>  	 * user page is the same as the virtual address that page
> @@ -108,6 +110,8 @@ void flush_ptrace_access(struct vm_area_struct *vma, struct page *page,
>  		for (; start < end; start += icache_line_size)
>  			flushi(start);
>  	}
> +
> +	preempt_enable();
>  }
>  
>  enum sparc_regset {

And this one also worked. Now I have a nice clean dmesg :)

Thanks,

	Mariusz
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/