Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758699AbYCZQGw (ORCPT ); Wed, 26 Mar 2008 12:06:52 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756417AbYCZQGa (ORCPT ); Wed, 26 Mar 2008 12:06:30 -0400 Received: from gprs189-60.eurotel.cz ([160.218.189.60]:4883 "EHLO spitz.ucw.cz" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753914AbYCZQG3 (ORCPT ); Wed, 26 Mar 2008 12:06:29 -0400 Date: Wed, 26 Mar 2008 00:10:35 +0100 From: Pavel Machek To: Alan Mayer Cc: torvalds@linux-foundation.org, mingo@elte.hu, linux-kernel list , Robin Holt , Jack Steiner , Russ Anderson Subject: Re: [PATCH] x86_64: resize NR_IRQS for large machines Message-ID: <20080325231034.GA3894@ucw.cz> References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.9i Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1331 Lines: 38 Hi! > Subject: [PATCH] x86_64: resize NR_IRQS for large machines > > From: Alan Mayer > > On machines with very large numbers of cpus, tables that are dimensioned > by NR_IRQS get very large, especially the irq_desc table. They are also > very sparsely used. When the cpu count is > MAX_IO_APICS, use MAX_IO_APICS > to set NR_IRQS, otherwise use NR_CPUS. > > Signed-off-by: Alan Mayer > > Reviewed-by: Christoph Lameter > =================================================================== > --- v2.6.25-rc6.orig/include/asm-x86/irq_64.h 2008-03-19 16:52:52.000000000 -0500 > +++ v2.6.25-rc6/include/asm-x86/irq_64.h 2008-03-20 16:46:51.000000000 -0500 > @@ -10,6 +10,10 @@ > * > */ > > +#if !defined(MAX_IO_APICS) > +#include > +#endif > + This is very ugly. Why not include it unconditionally -- with guard in apicdef.h? Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/