Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759429AbYCZSFd (ORCPT ); Wed, 26 Mar 2008 14:05:33 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756661AbYCZSFR (ORCPT ); Wed, 26 Mar 2008 14:05:17 -0400 Received: from az33egw01.freescale.net ([192.88.158.102]:41618 "EHLO az33egw01.freescale.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755246AbYCZSFJ (ORCPT ); Wed, 26 Mar 2008 14:05:09 -0400 Message-ID: <47EA903C.5030104@freescale.com> Date: Wed, 26 Mar 2008 13:04:44 -0500 From: Scott Wood User-Agent: Mozilla-Thunderbird 2.0.0.9 (X11/20080110) MIME-Version: 1.0 To: Jochen Friedrich CC: linuxppc-dev list , Anton Vorontsov , linux-kernel@vger.kernel.org Subject: Re: [PATCH] [POWERPC] CPM1: implement GPIO LIB API References: <47E92EC8.7010700@scram.de> <47E93350.6090806@freescale.com> <47EA8C1C.4090604@scram.de> In-Reply-To: <47EA8C1C.4090604@scram.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 893 Lines: 27 Jochen Friedrich wrote: > Hi Scott, > >>> diff --git a/arch/powerpc/platforms/8xx/Kconfig b/arch/powerpc/platforms/8xx/Kconfig >>> index 7fd224c..e12cbf0 100644 >>> --- a/arch/powerpc/platforms/8xx/Kconfig >>> +++ b/arch/powerpc/platforms/8xx/Kconfig >>> @@ -4,6 +4,8 @@ config FADS >>> config CPM1 >>> bool >>> select CPM >>> + select GENERIC_GPIO >>> + select GPIO_LIB >> Shouldn't this depend on the user enabling GPIO support? Some 8xx >> boards are very memory-constrained, so we don't want to be making the >> kernel even bigger than it already is unless it's actually needed. > > Are you more comfortable with this? Sure. -Scott -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/