Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1762361AbYCZS6S (ORCPT ); Wed, 26 Mar 2008 14:58:18 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1758115AbYCZS6B (ORCPT ); Wed, 26 Mar 2008 14:58:01 -0400 Received: from E23SMTP05.au.ibm.com ([202.81.18.174]:44819 "EHLO e23smtp05.au.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754831AbYCZS6A (ORCPT ); Wed, 26 Mar 2008 14:58:00 -0400 Message-ID: <47EA9BF2.2060301@linux.vnet.ibm.com> Date: Thu, 27 Mar 2008 00:24:42 +0530 From: Balbir Singh Reply-To: balbir@linux.vnet.ibm.com Organization: IBM User-Agent: Thunderbird 2.0.0.12 (X11/20080226) MIME-Version: 1.0 To: Balaji Rao CC: linux-kernel@vger.kernel.org, containers@lists.osdl.org, menage@google.com, balbir@in.ibm.com, dhaval@linux.vnet.ibm.com Subject: Re: [RFC][-mm] [2/2] Simple stats for memory resource controller References: <200803262348.59785.balajirrao@gmail.com> In-Reply-To: <200803262348.59785.balajirrao@gmail.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2050 Lines: 60 Balaji Rao wrote: > This patch implements trivial statistics for the memory resource controller. > > Signed-off-by: Balaji Rao > CC: Balbir Singh > CC: Dhaval Giani > > > diff --git a/mm/memcontrol.c b/mm/memcontrol.c > index eb681a6..84f3fe5 100644 > --- a/mm/memcontrol.c > +++ b/mm/memcontrol.c > @@ -45,6 +45,8 @@ enum mem_cgroup_stat_index { > */ > MEM_CGROUP_STAT_CACHE, /* # of pages charged as cache */ > MEM_CGROUP_STAT_RSS, /* # of pages charged as rss */ > + MEM_CGROUP_STAT_PGIN_COUNT, /* # of pages paged in */ > + MEM_CGROUP_STAT_PGOUT_COUNT, /* # of pages paged out */ > > MEM_CGROUP_STAT_NSTATS, > }; > @@ -196,6 +198,13 @@ static void mem_cgroup_charge_statistics(struct mem_cgroup *mem, int flags, > __mem_cgroup_stat_add_safe(stat, MEM_CGROUP_STAT_CACHE, val); > else > __mem_cgroup_stat_add_safe(stat, MEM_CGROUP_STAT_RSS, val); > + > + if (charge) > + __mem_cgroup_stat_add_safe(stat, > + MEM_CGROUP_STAT_PGIN_COUNT, 1); > + else > + __mem_cgroup_stat_add_safe(stat, > + MEM_CGROUP_STAT_PGOUT_COUNT, 1); > } > > static struct mem_cgroup_per_zone * > @@ -886,6 +895,8 @@ static const struct mem_cgroup_stat_desc { > } mem_cgroup_stat_desc[] = { > [MEM_CGROUP_STAT_CACHE] = { "cache", PAGE_SIZE, }, > [MEM_CGROUP_STAT_RSS] = { "rss", PAGE_SIZE, }, > + [MEM_CGROUP_STAT_PGIN_COUNT] = {"page_in_count", 1, }, > + [MEM_CGROUP_STAT_PGOUT_COUNT] = {"page_out_count", 1, }, > }; > > static int mem_control_stat_show(struct cgroup *cont, struct cftype *cft, Looks simple and nice. Please see Paul's mail on the suggested name change as well Acked-by: Balbir Singh -- Warm Regards, Balbir Singh Linux Technology Center IBM, ISTL -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/