Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755998AbYCZXqz (ORCPT ); Wed, 26 Mar 2008 19:46:55 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754060AbYCZXqr (ORCPT ); Wed, 26 Mar 2008 19:46:47 -0400 Received: from smtp1.linux-foundation.org ([140.211.169.13]:51663 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754047AbYCZXqr (ORCPT ); Wed, 26 Mar 2008 19:46:47 -0400 Date: Wed, 26 Mar 2008 16:43:57 -0700 (PDT) From: Linus Torvalds To: Ivan Kokshaysky cc: Gary Hade , Ingo Molnar , Thomas Meyer , Stefan Richter , Thomas Gleixner , "Rafael J. Wysocki" , LKML , Adrian Bunk , Andrew Morton , Natalie Protasevich , Benjamin Herrenschmidt , pm@debian.org Subject: Re: [patch] pci: revert "PCI: remove transparent bridge sizing" In-Reply-To: <20080326232922.GA15784@jurassic.park.msu.ru> Message-ID: References: <47E969E1.6080608@m3y3r.de> <20080326101450.GA9060@jurassic.park.msu.ru> <20080326135458.GA27621@elte.hu> <20080326180701.GA6249@us.ibm.com> <20080326203012.GB6249@us.ibm.com> <20080326205828.GA15225@jurassic.park.msu.ru> <20080326232922.GA15784@jurassic.park.msu.ru> User-Agent: Alpine 1.00 (LFD 882 2007-12-20) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1219 Lines: 29 On Thu, 27 Mar 2008, Ivan Kokshaysky wrote: > > If the new "align" field (and then, maybe, "size" instead of "end"?) > is OK, then I'm definitely willing to give it a try. Adding an alignment field should be a non-issue: the size of this structure is not likely to be a big deal (yeah, we have something like 12 of them in each PCI device etc, so smaller is better, but it's still not going to be something anybody really notices). And yeah, it might be nice to have "size" instead of "end", but the real problem with that one is actually that on 32-bit (without the 64-bit resource configuration) we want it to be "size-1" in order to be able to fit a whole 0-0xffffffff resource into a resource. And *that* would be really ugly with "size": at least right now it makes a certain amount of sense with "end" pointing to the last entry. So while I can understand your wish for "start+len" rather than "start+end", I don't think it's really practical. Linus -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/