Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756518AbYCZXsI (ORCPT ); Wed, 26 Mar 2008 19:48:08 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752954AbYCZXr4 (ORCPT ); Wed, 26 Mar 2008 19:47:56 -0400 Received: from gate.crashing.org ([63.228.1.57]:37334 "EHLO gate.crashing.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751878AbYCZXrz (ORCPT ); Wed, 26 Mar 2008 19:47:55 -0400 Subject: Re: [patch] pci: revert "PCI: remove transparent bridge sizing" From: Benjamin Herrenschmidt Reply-To: benh@kernel.crashing.org To: Ivan Kokshaysky Cc: Linus Torvalds , Gary Hade , Ingo Molnar , Thomas Meyer , Stefan Richter , Thomas Gleixner , "Rafael J. Wysocki" , LKML , Adrian Bunk , Andrew Morton , Natalie Protasevich , pm@debian.org In-Reply-To: <20080326232922.GA15784@jurassic.park.msu.ru> References: <47E969E1.6080608@m3y3r.de> <20080326101450.GA9060@jurassic.park.msu.ru> <20080326135458.GA27621@elte.hu> <20080326180701.GA6249@us.ibm.com> <20080326203012.GB6249@us.ibm.com> <20080326205828.GA15225@jurassic.park.msu.ru> <20080326232922.GA15784@jurassic.park.msu.ru> Content-Type: text/plain Date: Thu, 27 Mar 2008 10:45:49 +1100 Message-Id: <1206575149.6926.57.camel@pasglop> Mime-Version: 1.0 X-Mailer: Evolution 2.12.1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1201 Lines: 32 On Thu, 2008-03-27 at 02:29 +0300, Ivan Kokshaysky wrote: > Well, at this point (pdev_sort_resources call) bridge resource->start > has nothing to do with a bus address, it just a temporary storage for > required alignment, filled by sizing routines (and 0 is definitely > invalid here). Allright, that sounds better then. > I know, this is quite confusing, but I didn't want to add extra > fields to existing structures or create temporary per-bus trees... > But after pci_assign_resource() that resource can certainly be at 0, > depending on PCIBIOS_MIN_{IO,MEM} and free slots in the resource tree. In fact, this is the resource assignment code, and PCIBIOS_MIN_* is set to non-0 for powerpc too so we don't try to assign things down at 0 anyway, so we don't have a problem. We only care about things at 0 that have already been put there by the firmware and that we decide not to reassign. So I don't have any objection anymore. Cheers, Ben. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/