Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757058AbYC0CyS (ORCPT ); Wed, 26 Mar 2008 22:54:18 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754653AbYC0CyE (ORCPT ); Wed, 26 Mar 2008 22:54:04 -0400 Received: from gate.crashing.org ([63.228.1.57]:42770 "EHLO gate.crashing.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754309AbYC0CyD (ORCPT ); Wed, 26 Mar 2008 22:54:03 -0400 Subject: Re: [RFC][PATCH 1/3] PM: Introduce new top level suspend and hibernation callbacks (rev. 4) From: Benjamin Herrenschmidt Reply-To: benh@kernel.crashing.org To: "Rafael J. Wysocki" Cc: Alexey Starikovskiy , pm list , ACPI Devel Maling List , Alan Stern , Greg KH , Len Brown , LKML , David Brownell , Pavel Machek , Oliver Neukum In-Reply-To: <200803270223.06715.rjw@sisk.pl> References: <200803262353.30566.rjw@sisk.pl> <200803270054.58546.rjw@sisk.pl> <1206576403.6926.62.camel@pasglop> <200803270223.06715.rjw@sisk.pl> Content-Type: text/plain Date: Thu, 27 Mar 2008 13:52:38 +1100 Message-Id: <1206586358.6926.68.camel@pasglop> Mime-Version: 1.0 X-Mailer: Evolution 2.12.1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 933 Lines: 27 On Thu, 2008-03-27 at 02:23 +0100, Rafael J. Wysocki wrote: > On Thursday, 27 of March 2008, Benjamin Herrenschmidt wrote: > > > > > > There is absolutely no point getting a second struct anymore. > > > > > > I obviously disagree with that opinion, so please elaborate. > > > > Well, what does it bring you ? Why can't it be one struct ? To save > > space in the data area ? > > Mostly, but not only that. > > There are users of 'struct pm_ops' that aren't even supposed to define the > _noirq callbacks (device types and device classes), so I thought it would be > better to introduce a separate _noirq struct after all. Make sense... USB has no use of noirq for example. Ben. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/